recommendations from fedora

Added by Chitlesh Goorah over 3 years ago

Hello there,

While I'm packaging perl-verilof for fedora, I have the following suggestions to update in the sources: #1 chmod -x t/*.{t,v} on your repositories

#2 Add the ";" to the line 1062 of Parser/VParseBison.y

- idDotted '(' exprList ')' { $1+"("+$3+")" } + idDotted '(' exprList ')' { $1+"("+$3+")"; }

Because in the latest bison the compilation fails.

#3 There are some missing requires in your package

Requires: perl(Test::Pod) Requires: perl(Pod::Usage)

Requires: perl(Test) Requires: perl(warnings) Requires: perl(Data::Dumper)

#4 A more delicate problem are the scripts named vpm and vppp. According to https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace , commands whose names are shorter than 5 letters should be avoided. Fortunately vpm does not seem to conflict with anything, but vppp is also the name of the Virtual PPP project by packagestorm and is also used by http://www.linux-kheops.com/pub/vppp/vpppGB.html

Can you change the filename of the files on /usr/bin to avoid such conflict ? I understand that this modification will require and update of the documentation as well, however in the future, if this is not corrected now will create some problems on other linux distributions as well.

Replies (1)

RE: recommendations from fedora - Added by Wilson Snyder over 3 years ago

#1 chmod -x t/*.{t,v} on your repositories

The .t's should be executable because it's very reasonable to execute them standalone for testing.

Really neither should matter as they don't get installed.

#2 Add the ";" to the line 1062 of Parser/VParseBison.y

Done.

#3 There are some missing requires in your package

Requires: perl(Test::Pod) Requires: perl(Pod::Usage) Requires: perl(Test) Requires: perl(warnings) Requires: perl(Data::Dumper)

Did you really have a problem? I'm guessing not. Pod::Usage was already listed and Test::Pod is not required for non-authors. I added warnings and Data::Dumper, though I believe all are part of the standard perl distributions.

#4 A more delicate problem are the scripts named vpm and vppp.

Sigh. I unfortunately see your point. I've renamed vppp to vperlpp, and am debating new names for vpm.

(1-1/1)