[logo] 
 
Home
News
Activity
About/Contact
Major Tools
  Dinotrace
  Verilator
  Verilog-mode
  Verilog-Perl
Other Tools
  BugVise
  CovVise
  Force-Gate-Sim
  Gspice
  IPC::Locker
  Rsvn
  SVN::S4
  SystemPerl
  Voneline
  WFH
General Info
  Papers

Issue #518

wrong return value check

Added by Wei Song about 1 year ago. Updated 10 months ago.

Status:Closed Start date:05/22/2012
Priority:Low Due date:
Assignee:Wilson Snyder % Done:

0%

Category:-
Target version:-

Description

In VPreProc.cpp: function VPreProcImp::readWholefile

The "open" function returns -1 when failing to open a file. However, "if(!fd)" will fail to check the error.

I found this problem as I am directly using the preprocessor in my own project. Running with the perl wrapper will not show any problem because, to my understanding, perl will first check the file existence.

History

Updated by Wilson Snyder 12 months ago

  • Status changed from New to Resolved
  • Assignee set to Wilson Snyder

Good point, thanks for reporting it. Fixed in git towards 3.316+.

Updated by Wilson Snyder 10 months ago

  • Status changed from Resolved to Closed

In 3.316.

Also available in: Atom