Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting issue since 9797a275 #1002

Closed
veripoolbot opened this issue Nov 19, 2015 · 2 comments
Closed

Syntax highlighting issue since 9797a275 #1002

veripoolbot opened this issue Nov 19, 2015 · 2 comments
Assignees

Comments

@veripoolbot
Copy link
Collaborator


Author Name: Paul Sargent
Original Redmine Issue: 1002 from https://www.veripool.org
Original Date: 2015-11-19
Original Assignee: Wilson Snyder (@wsnyder)


The change introduced in 9797a27 seems to have had a negative effect on syntax highlighting for me.

I've attached a file which shows the issue for me. At the start the syntax highlighting seems fine, but despite @new()@ being highlighted on lines 38 to 43, it isn't on line 44. After that point only strings, @function@/@endfunction@ and comments are highlighted. It's as if the highlighter has gone into a reduced mode halfway through the buffer.

I traced the changeset above with 'git bisect'. Revisions prior to this work as expected.

I'm on GNU Emacs 23.4.1. My init.el lines for verilog mode follow:

;; Load verilog mode only when needed 
(autoload 'verilog-mode "verilog-mode" "Verilog mode" t ) 

;; Any files that end in .v, .dv or .sv should be in verilog mode 
(add-to-list 'auto-mode-alist '("\\.[ds]?vh?\\'" . verilog-mode)) 
;; Any files in verilog mode should have their keywords colorized 
(add-hook 'verilog-mode-hook '(lambda () (font-lock-mode 1))) 

(load "folding" 'nomessage 'noerror)
(folding-mode-add-find-file-hook)
(folding-add-to-marks-list 'verilog-mode  "/*{"  "/*}"  nil t)

(custom-set-variables
 '(verilog-auto-delete-trailing-whitespace t)
 '(verilog-auto-newline nil)
 '(verilog-case-indent 4)
 '(verilog-cexp-indent 4)
 '(verilog-highlight-grouping-keywords t)
 '(verilog-highlight-p1800-keywords t)
 '(verilog-indent-begin-after-if nil)
 '(verilog-indent-level 4)
 '(verilog-indent-level-behavioral 4)
 '(verilog-indent-level-declaration 4)
 '(verilog-indent-level-directive 4)
 '(verilog-indent-level-module 4)
 '(verilog-indent-lists t))

@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2015-11-26T14:05:16Z


This is a core Emacs bug. Attached is a tarball I am sending upstream.

In the meantime I suggest not setting verilog-highlight-grouping-keywords.

@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2015-12-01T23:10:44Z


This is fixed in the git trunk, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants