Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port declaration lineup problem with custom types #1014

Closed
veripoolbot opened this issue Dec 14, 2015 · 2 comments
Closed

Port declaration lineup problem with custom types #1014

veripoolbot opened this issue Dec 14, 2015 · 2 comments
Labels
duplicate indents

Comments

@veripoolbot
Copy link
Collaborator

Author Name: Ned Guthrie
Original Redmine Issue: 1014 from https://www.veripool.org

When port declarations are lined up I get unexpected behavior for ports that are custom types. Here is what I see:

     output logic              normal_porta,
     output logic [PORTW-1:0]  normal_portb,
     output                    datatypes_pkg::some_t some_port,
     output                    datatypes_pkg::some_other_long_t some_other_port,
     output                    datatypes_pkg::a_t short_port,

As you can see it it pretty hard to pick out the port names here. What I would rather see is the port type and the port name lined up:

     output logic                             normal_porta,
     output logic [PORTW-1:0]                 normal_portb,
     output datatypes_pkg::some_t             some_port,
     output datatypes_pkg::some_other_long_t  some_other_port,
     output datatypes_pkg::a_t                short_port,

This is with version 2013-11-05-78e66ba-vpo. Do I just have things configured wrong, or is this expected behavior?

Thanks,
Ned
@veripoolbot
Copy link
Collaborator Author

Original Redmine Comment
Author Name: Ned Guthrie
Original Date: 2015-12-14T18:38:40Z

Of course after I submitted this I found the issues where others had already made the same request and submitted patches. Sounds like an update is in the works on this.

@veripoolbot
Copy link
Collaborator Author

Original Redmine Comment
Author Name: Ned Guthrie
Original Date: 2015-12-14T18:41:28Z

Issue #904 appears to cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate indents
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veripoolbot