Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit bf5dee955d8555b0e0b25 leads to miscompiled design #1022

Closed
veripoolbot opened this issue Jan 12, 2016 · 2 comments
Closed

commit bf5dee955d8555b0e0b25 leads to miscompiled design #1022

veripoolbot opened this issue Jan 12, 2016 · 2 comments
Assignees
@wsnyder
Labels
resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Duraid Madina
Original Redmine Issue: 1022 from https://www.veripool.org
Original Date: 2016-01-12
Original Assignee: Wilson Snyder (@wsnyder)

Commit bf5dee9 ("Fix real parameters causing bad modules names, bug 992") causes Verilator to miscompile a production design I have. The culprit seems to be the presence of:

constp->num().isNegative()

around src/V3Param.cpp:475

at least in the sense that removing the above expression resolves the issue.
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2016-01-21T03:09:21Z

I do not understand how changing the module name would make your design have problems, and suspect this is just paper-overing another issue. If you find it later, please file another issue on that.

However I agree isNegative isn't needed in this code. That's fixed in git towards 3.882.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2016-03-02T00:16:07Z

In 3.882.

@veripoolbot veripoolbot added the resolution: fixed Closed; fixed label Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsnyder wsnyder

Labels
resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsnyder @veripoolbot