Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up --no-decoration mode for V3OutputFormatter #1093

Closed
veripoolbot opened this issue Sep 22, 2016 · 3 comments
Closed

Speed up --no-decoration mode for V3OutputFormatter #1093

veripoolbot opened this issue Sep 22, 2016 · 3 comments
Labels
resolution: no fix needed Closed; no fix required (not a bug)

Comments

@veripoolbot
Copy link
Contributor


Author Name: Johan Bjork
Original Redmine Issue: 1093 from https://www.veripool.org


Two commits in the branch:
First commit expands --no-decoration mode to skip format tracking completely and only keep basic expression splitting on long lines. The change is fairly small but it's not the cleanest change. A larger refactor of the output/formatter class might be in order at some point.
The second commit removes the putAlign() code, which has been disabled for a long time and seems unlikely to be enabled again.

https://github.com/phb/verilator-dev/tree/master

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Johan Bjork
Original Date: 2016-09-22T14:07:27Z


Johan Bjork wrote:

Two commits in the branch:
First commit expands --no-decoration mode to skip format tracking completely and only keep basic expression splitting on long lines. The change is fairly small but it's not the cleanest change. A larger refactor of the output/formatter class might be in order at some point.
The second commit removes the putAlign() code, which has been disabled for a long time and seems unlikely to be enabled again.

https://github.com/phb/verilator-dev/tree/master

hold off on this -- I broke something in cleaning up the patch.

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-08-29T03:05:07Z


Removal of putAlign() was pushed to trunk.

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-11-06T02:55:13Z


I think this was relatively abandoned beyond the alignment change which was pushed earlier, feel free to reopen a new bug if you have a complete patch and see it helps performance noticeably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: no fix needed Closed; no fix required (not a bug)
Projects
None yet
Development

No branches or pull requests

1 participant