Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage Declarations does not honor output split cfuncs #1098

Closed
veripoolbot opened this issue Oct 22, 2016 · 3 comments
Closed

Coverage Declarations does not honor output split cfuncs #1098

veripoolbot opened this issue Oct 22, 2016 · 3 comments
Labels
resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor


Author Name: Johan Bjork
Original Redmine Issue: 1098 from https://www.veripool.org

Original Assignee: Johan Bjork


Hey Wilson,

Changed V3EmitC to call a predefined function for initializing coverage and moved that function creation to the same place as where the variable resets are being created. This makes it possible to compile large projects (w/ heavy inlining) with coverage. (Without this patch the C++ would never finish due to the ::configure() method being way too large)

Patch here: phb/verilator-dev@ad106e4

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Johan Bjork
Original Date: 2016-10-22T18:32:37Z


Sorry, sent the wrong commithash. This is the correct one:

phb/verilator-dev@92e6c49

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2016-10-23T18:30:19Z


Applied to git towards 3.889.

All looked good thanks!

My only change was going to be to rename the visitor to the new standard, then realized the name just seemed too long to me (V3CConstructorsVisitor). I'm not really in love with how I renamed the file to make it feel better either (V3CCtors) but it'll do.

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2016-11-25T16:01:52Z


In 3.890.

@veripoolbot veripoolbot added the resolution: fixed Closed; fixed label Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution: fixed Closed; fixed
Projects
None yet
Development

No branches or pull requests

1 participant