Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SmallName for ParamTypeDType #1101

Closed
veripoolbot opened this issue Nov 4, 2016 · 1 comment
Closed

Fix SmallName for ParamTypeDType #1101

veripoolbot opened this issue Nov 4, 2016 · 1 comment
Labels
resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Stefan Wallentowitz (@wallento)
Original Redmine Issue: 1101 from https://www.veripool.org

Original Assignee: Stefan Wallentowitz (@wallento)

Hi Wilson,

based on the discussion here (chipsalliance/chisel#293) I found that type parameters lead to a problem with generated files and emitted code with -O0, because SmallNames did not set a character. Hence \000 was used, with the file name and content getting messed up.

The SmallName of type parameters needs to be generated, otherwise files/modules with character \000 were generated after calling paramSmallName.

With this patch the SmallName 'T' is used for type parameters.
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2016-11-05T02:59:00Z

Great! Pushed to git towards 3.889.

@veripoolbot veripoolbot added the resolution: fixed Closed; fixed label Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veripoolbot