Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wreal implicit assignments don't reevaluate #1150

Closed
veripoolbot opened this issue Mar 30, 2017 · 4 comments
Closed

wreal implicit assignments don't reevaluate #1150

veripoolbot opened this issue Mar 30, 2017 · 4 comments
Assignees
@wsnyder
Labels
area: wrong runtime result Issue involves an incorrect runtine result from Verilated model resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: j briquet
Original Redmine Issue: 1150 from https://www.veripool.org

Original Assignee: Wilson Snyder (@wsnyder)

Hello,

I am currently using Verilator's tool to convert some wreal models in SystemC, knowing some limitations or unsupported features.
As for now, I was able to verilate some basics models. But, I recently faced an issue when substracting two wreal signals, to evaluate if the result is within or not a certain range. Actually, if you refer to the below code, I observed that the intermediate signal "in_int" stays always to 0.0 when vin > gnd.
I created a very simple test case with a systemC testbench, that you can find in attachment. To run it, just need to go to test_sc and type the command : make .

Best regards,
J-P

module within_range(vin,gnd,out);

input vin;
input gnd;
output out;

parameter real V_MIN = 0.5;
parameter real V_MAX = 10;

`begin_keywords "1800+VAMS"
wreal vin;
wreal gnd;
wreal in_int = vin - gnd;
wire out = (V_MIN <= in_int && in_int <= V_MAX);

`end_keywords

endmodule
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: j briquet
Original Date: 2017-03-30T08:18:46Z

Please find all the necessary files, tar file seems to be filtered. If you need more information, please do not hesitate.
Thanks,
J-P

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-03-30T22:36:13Z

As you noted AMS doesn't have much support, but this certainly should have worked. Turns out it was incorrectly ignoring the continuous assignment aspect. Thanks for the test.

Fixed in git towards 3.902.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: j briquet
Original Date: 2017-03-30T23:26:09Z

Thanks for your quick support, I will give it a try later and let you know. J-P

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2017-04-02T12:52:54Z

In 3.902.

@veripoolbot veripoolbot added area: wrong runtime result Issue involves an incorrect runtine result from Verilated model resolution: fixed Closed; fixed labels Dec 22, 2019
@wsnyder wsnyder mentioned this issue May 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsnyder wsnyder

Labels
area: wrong runtime result Issue involves an incorrect runtine result from Verilated model resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsnyder @veripoolbot