Project

General

Profile

[logo] 
 
Home
News
Activity
About/Contact
Major Tools
  Dinotrace
  Verilator
  Verilog-mode
  Verilog-Perl
Other Tools
  BugVise
  CovVise
  Force-Gate-Sim
  Gspice
  IPC::Locker
  Rsvn
  SVN::S4
  Voneline
  WFH
General Info
  Papers

Issue #1200

Concat parsing issue

Added by Wilson Snyder over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
% Done:

0%


Description

From https://www.veripool.org/boards/28/topics/1626?r=2332#message-2332

aaaand we are back :P Apparently there is a bug, where not enough cleanup is done... following commit fixes this. https://github.com/uastw-embsys/Verilog-Perl/commit/0ef1bbb06e326ddf96361f49afda62d673b8cd04

Stefan, nit - please file issues so I don't miss patches. Anyhow when I patch and run 42_dumpcheck.t a bunch of times I sometimes get "Attempt to free unreferenced scalar: SV 0x23e4b30, Perl interpreter: .... during global destruction." so something is still unstable. Can you run it in a loop and take a look?

0001-Fix-Attempt-to-free-unreferenced-scalar-in-pinselect.patch View (785 Bytes) Stefan Tauner, 09/07/2017 04:05 PM

History

#1 Updated by Stefan Tauner over 1 year ago

Wilson Snyder wrote:

From https://www.veripool.org/boards/28/topics/1626?r=2332#message-2332

aaaand we are back :P Apparently there is a bug, where not enough cleanup is done... following commit fixes this. https://github.com/uastw-embsys/Verilog-Perl/commit/0ef1bbb06e326ddf96361f49afda62d673b8cd04

Stefan, nit - please file issues so I don't miss patches.

NP, I pondered about it but thought keeping it all together in the thread is better...

Anyhow when I patch and run 42_dumpcheck.t a bunch of times I sometimes get "Attempt to free unreferenced scalar: SV 0x23e4b30, Perl interpreter: .... during global destruction." so something is still unstable. Can you run it in a loop and take a look?

I can reproduce what you see in about 5% of the runs. However, it is not this patch that is producing this problem. I have git bisected this and can conclude that it was introduced already in 3d2ecdb Support for buses and concats in Netlist, msg1626. Will look into it further now-ish...

#2 Updated by Stefan Tauner over 1 year ago

That one hurts a bit... one work day led to the attached (and also pushed) patch :'( The other patch is nevertheless needed to fix the other problem. Sorry!

#3 Updated by Wilson Snyder over 1 year ago

  • Status changed from New to Resolved

Excellent work, again.

Pushed both to git towards 3.441. I'll wait a day for this to settle then push out a release.

#4 Updated by Wilson Snyder over 1 year ago

  • Status changed from Resolved to Closed

In 3.442.

Also available in: Atom