Original Redmine Comment
Author Name: Patrick Stewart
Original Date: 2018-02-21T04:22:44Z

Sorry, that should be: "patstew@f3fa47a6791815619b7bf749be2be92d9cc985ac":https://github.com/patstew/verilator/commit/f3fa47a6791815619b7bf749be2be92d9cc985ac

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2018-02-21T16:06:01Z

Nicely done. Do any if these return exceptions with e.g. 0 inputs? If so can you please have the test check that, and they will need guarding at execution with a conditional ?:.

Original Redmine Comment
Author Name: Patrick Stewart
Original Date: 2018-02-21T16:51:19Z

Do you mean the C++ math functions? None of the @@ functions raise exceptions, they just return @nan@ or @+-inf@ if you put in an out of range argument. The systemverilog standard (20.8.2) says

bq. Their behavior shall match the equivalent C language standard math library function indicated

so I assume that's ok.

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2018-02-26T09:26:16Z

Pushed patch to git (with minor space changes) towards 3.922.

Thanks again for your effort.

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2018-03-17T16:03:26Z

In 3.922.