Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespaces in codebase #1301

Closed
veripoolbot opened this issue Apr 18, 2018 · 2 comments
Closed

Whitespaces in codebase #1301

veripoolbot opened this issue Apr 18, 2018 · 2 comments
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: wontfix Closed; work won't continue on an issue or pull request

Comments

@veripoolbot
Copy link
Contributor


Author Name: Stefan Wallentowitz (@wallento)
Original Redmine Issue: 1301 from https://www.veripool.org


Hi Wilson,

without the intent to start a religious war ;)
I am wondering if you have any strong feelings about whitespaces in the codebase. Each time I open the code in another editor I am faced with indentation.

It seems to be roughly like this:

  • Generally indentation is four spaces
  • Tabs seem to be 8
  • Hence the first level indentation is four spaces, the second one is one tab, etc.
  • Alignment (such as variable assignments) seem to be mostly done with tabs
  • Contributors used spaces for indentation sometimes

Without any preference I am wondering if you are interested in a patch unifying it for example to spaces with indentation of four spaces, or to tabs with tab width 4. I would volunteer for this.

It is not that I see a big issue, but maybe some housekeeping.

Cheers,
Stefan

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2018-04-19T13:53:17Z


Verilator used the gnu standard indentation of 4, with tabs always 8.

However I have given up on this as the world seems to have gone to spaces - all new commits are untabified.

I do not want to make a mass change at this point as it screws merges; in 2020 or so after enough code is untabified probably.

@veripoolbot
Copy link
Contributor Author


Original Redmine Comment
Author Name: Stefan Wallentowitz (@wallento)
Original Date: 2018-04-19T18:35:56Z


Hi Wilson,

thanks a lot for pointing out. I obviously missed that this is the GNU coding style. Fully agree to your approach.

Cheers,
Stefan

@veripoolbot veripoolbot added area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: wontfix Closed; work won't continue on an issue or pull request labels Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: wontfix Closed; work won't continue on an issue or pull request
Projects
None yet
Development

No branches or pull requests

1 participant