Project

General

Profile

[logo] 
 
Home
News
Activity
About/Contact
Major Tools
  Dinotrace
  Verilator
  Verilog-mode
  Verilog-Perl
Other Tools
  BugVise
  CovVise
  Force-Gate-Sim
  Gspice
  IPC::Locker
  Rsvn
  SVN::S4
  Voneline
  WFH
General Info
  Papers

Issue #1327

Strange initialisation behaviour with "VinpClk" cloned clock variables

Added by Rupert Swarbrick 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
WrongRuntimeResult
% Done:

0%


Description

We're seeing a strange behaviour in our system testbench. I've tracked it down to a problem with (seemingly) spurious edges on a clock variable. I think that Verilator is misbehaving, but if this is correct and we're just Doing It Wrong (TM), it would be great to understand why.

Our system testbench includes a DUT and a memory block connected together. We generate clock and (asynchronous) reset signals for these two blocks by gating the clock and reset signals of the testbench using an FSM which steps through the test.

As a result of this logic, I think Verilator decides that the testbench's "memory_rst_n" variable (which is wired to the reset pin of the memory) has a cycle and generates a "VinpClk" variable for it.

In the memory model, there is a block of the form

always @(posedge clk or negedge rst_n) begin
  $display("%0d %0d", clk, rst_n);
  if (rst_n) begin
    ...
  end else begin
    ...
  end
end

The logic to decide when to schedule the always block generates the following C++ code:

if ((((IData)(vlTOPp->clk) & (~ (IData)(vlTOPp->_Vclklast_TOP__clk)))
     | ((~ (IData)(vlTOPp->_VinpClk_TOP__top__DOT__tb_i__DOT__memory_rst_n))
        & (IData)(vlTOPp->Vclklast__TOP_VinpClk_TOP__top__DOT__tb_i__DOT__memory_rst_n)))) {
    vlTOPp->sequent_TOP__5(vlSymsp);
    vlTOPp->_Vm_traceActivity = (8U | vlTOPp->_Vm_traceActivity);
    vlTOPp->sequent_TOP__6(vlSymsp);
}

This makes sense to me: the block executes on a posedge of the toplevel clock or a negedge of the renamed memory_rst_n variable.

Reads from the memory_rst_n variable in the block get turned into code like this:

VL_WRITEF("%0# %0#\n",1,vlTOPp->clk,1,(IData)(vlTOPp->top__DOT__tb_i__DOT__memory_rst_n));
if (VL_UNLIKELY(vlTOPp->top__DOT__tb_i__DOT__memory_rst_n)) {
  ...
}

When running our testbench, we call Verilated::randReset(2) to ask for random initialisation. What we see is that the always block shown above executes at initialisation time but the $display call shows clk=0 and rst_n=1 (so there shouldn't have been either type of edge). Shortly afterwards, the simulation falls over because the memory model doesn't expect this to happen.

Investigating with GDB shows the following values:

(gdb) p vlTOPp->top__DOT__tb_i__DOT__memory_rst_n
$1 = 1 '\001'
(gdb) p vlTOPp->_Vchglast_TOP__top__DOT__tb_i__DOT__memory_rst_n
$2 = 0 '\000'
(gdb) p vlTOPp->_VinpClk_TOP__top__DOT__tb_i__DOT__memory_rst_n
$3 = 0 '\000'
(gdb) p vlTOPp->Vclklast__TOP_VinpClk_TOP__top__DOT__tb_i__DOT__memory_rst_n
$4 = 1 '\001'

That is, there has actually been a posedge on rst_n, but there is an apparent negedge on the VinpClk clone.

Since this seemed to be some sort of strange reset behaviour, I did some further digging to see how these variables were initialised:

$ grep n 'top__DOT__tb_i__DOT__memory_rst_n.*=' *.cpp | grep -v - '->'
Vtop__10__Slow.cpp:410:    _VinpClk_TOP__top__DOT__tb_i__DOT__memory_rst_n = 0;
Vtop__10__Slow.cpp:412:    Vclklast__TOP_VinpClk_TOP__top__DOT__tb_i__DOT__memory_rst_n = VL_RAND_RESET_I(1);
Vtop__10__Slow.cpp:418:    _Vchglast_TOP__top__DOT__tb_i__DOT__memory_rst_n = 0;
Vtop__8__Slow.cpp:255:    top__DOT__tb_i__DOT__memory_rst_n = 0;

Note that all the fields except the "last" version of the cloned variable are initialised to zero. If I hack the generated C++ code to initialise all four fields to zero, the spurious negedge goes away and everything works.

The initial values of these fields seem to be controlled by the "zeroit" flag in V3EmitC.cpp, but I don't know enough about Verilator's type infrastructure to get further easily.

Is it possible that something that controls the underlying type of the variable wasn't copied across in ClockVisitor::getCreateLastClk()?

0001-Code-that-exhibits-bug-1327-in-test-regress-format.patch View - Patch that adds the failing testcase (5.03 KB) Rupert Swarbrick, 08/30/2018 11:15 AM

History

#1 Updated by Wilson Snyder 4 months ago

I suspect the code should be changed to at init time after rand reset, set all last vars = the normal non-last value.

Does doing that fix your example?

Can you try to make an example in test regress format (see the docs) showing the problem please?

#2 Updated by Wilson Snyder 4 months ago

  • Status changed from New to AskedReporter

#3 Updated by Rupert Swarbrick 4 months ago

Hi there,

Sorry for the slow reply. I've written a silly test that shows this. I suspect it's a little flaky (because it depends on the random number generator giving different initialisations for the rst_n variables). If it doesn't fail for you, try changing the randReset to a different number.

When I run things, this is what I get:

rjs@rjs-argon:~/tool-source/verilator/test_regress$ ./driver.pl --vlt t_vinpclk_initialisation.pl
======================================================================
vlt/t_vinpclk_initialisation: ==================================================
vlt/t_vinpclk_initialisation: Compile
        perl ../bin/verilator --prefix Vt_vinpclk_initialisation --x-assign unique -cc -Mdir obj_vlt/t_vinpclk_initialisation -OD --debug-check --comp-limit-members 10 -CFLAGS -g3 --exe /home/rjs/tool-source/verilator/test_regress/t/t_vinpclk_initialisation.cpp --clk clk  -f input.vc +define+TEST_OBJ_DIR=obj_vlt/t_vinpclk_initialisation t/t_vinpclk_initialisation.v    > obj_vlt/t_vinpclk_initialisation/vlt_compile.log
vlt/t_vinpclk_initialisation: GCC
        make -C obj_vlt/t_vinpclk_initialisation -f /home/rjs/tool-source/verilator/test_regress/Makefile_obj VM_PREFIX=Vt_vinpclk_initialisation TEST_OBJ_DIR=obj_vlt/t_vinpclk_initialisation CPPFLAGS_DRIVER=-DT_VINPCLK_INITIALISATION  MAKE_MAIN=0  Vt_vinpclk_initialisation    > obj_vlt/t_vinpclk_initialisation/vlt_gcc.log
make: Entering directory '/home/rjs/tool-source/verilator/test_regress/obj_vlt/t_vinpclk_initialisation'
g++  -I.  -MMD -I/home/rjs/tool-source/verilator/test_regress/../include -I/home/rjs/tool-source/verilator/test_regress/../include/vltstd -DVL_PRINTF=printf -DVM_COVERAGE=0 -DVM_SC=0 -DVM_TRACE=0 -faligned-new -Wno-bool-operation -Wno-sign-compare -Wno-uninitialized -Wno-unused-but-set-variable -Wno-unused-parameter -Wno-unused-variable -Wno-shadow     -g3  -DVERILATOR=1 -DVL_DEBUG=1 -DTEST_OBJ_DIR=obj_vlt/t_vinpclk_initialisation -DVM_PREFIX=Vt_vinpclk_initialisation -DVM_PREFIX_INCLUDE="<Vt_vinpclk_initialisation.h>" -DT_VINPCLK_INITIALISATION    -c -o t_vinpclk_initialisation.o /home/rjs/tool-source/verilator/test_regress/t/t_vinpclk_initialisation.cpp
/usr/bin/perl /home/rjs/tool-source/verilator/test_regress/../bin/verilator_includer -DVL_INCLUDE_OPT=include Vt_vinpclk_initialisation.cpp > Vt_vinpclk_initialisation__ALLcls.cpp
g++  -I.  -MMD -I/home/rjs/tool-source/verilator/test_regress/../include -I/home/rjs/tool-source/verilator/test_regress/../include/vltstd -DVL_PRINTF=printf -DVM_COVERAGE=0 -DVM_SC=0 -DVM_TRACE=0 -faligned-new -Wno-bool-operation -Wno-sign-compare -Wno-uninitialized -Wno-unused-but-set-variable -Wno-unused-parameter -Wno-unused-variable -Wno-shadow     -g3  -DVERILATOR=1 -DVL_DEBUG=1 -DTEST_OBJ_DIR=obj_vlt/t_vinpclk_initialisation -DVM_PREFIX=Vt_vinpclk_initialisation -DVM_PREFIX_INCLUDE="<Vt_vinpclk_initialisation.h>" -DT_VINPCLK_INITIALISATION    -c -o Vt_vinpclk_initialisation__ALLcls.o Vt_vinpclk_initialisation__ALLcls.cpp
/usr/bin/perl /home/rjs/tool-source/verilator/test_regress/../bin/verilator_includer -DVL_INCLUDE_OPT=include Vt_vinpclk_initialisation__Syms.cpp > Vt_vinpclk_initialisation__ALLsup.cpp
g++  -I.  -MMD -I/home/rjs/tool-source/verilator/test_regress/../include -I/home/rjs/tool-source/verilator/test_regress/../include/vltstd -DVL_PRINTF=printf -DVM_COVERAGE=0 -DVM_SC=0 -DVM_TRACE=0 -faligned-new -Wno-bool-operation -Wno-sign-compare -Wno-uninitialized -Wno-unused-but-set-variable -Wno-unused-parameter -Wno-unused-variable -Wno-shadow     -g3  -DVERILATOR=1 -DVL_DEBUG=1 -DTEST_OBJ_DIR=obj_vlt/t_vinpclk_initialisation -DVM_PREFIX=Vt_vinpclk_initialisation -DVM_PREFIX_INCLUDE="<Vt_vinpclk_initialisation.h>" -DT_VINPCLK_INITIALISATION    -c -o Vt_vinpclk_initialisation__ALLsup.o Vt_vinpclk_initialisation__ALLsup.cpp
      Archiving Vt_vinpclk_initialisation__ALL.a ...
ar r Vt_vinpclk_initialisation__ALL.a Vt_vinpclk_initialisation__ALLcls.o Vt_vinpclk_initialisation__ALLsup.o
ranlib Vt_vinpclk_initialisation__ALL.a
g++    t_vinpclk_initialisation.o verilated.o Vt_vinpclk_initialisation__ALL.a    -o Vt_vinpclk_initialisation -lm -lstdc++
make: Leaving directory '/home/rjs/tool-source/verilator/test_regress/obj_vlt/t_vinpclk_initialisation'
vlt/t_vinpclk_initialisation: Run
        obj_vlt/t_vinpclk_initialisation/Vt_vinpclk_initialisation    > obj_vlt/t_vinpclk_initialisation/vlt_sim.log
Oh dear! 'always @(posedge clk or negedge rst_n)' block triggered with clk=0, rst_n=1.
%Error: t/t_vinpclk_initialisation.v:22: Verilog $stop
Aborting...
%Warning: vlt/t_vinpclk_initialisation: Exec of obj_vlt/t_vinpclk_initialisation/Vt_vinpclk_initialisation failed: Oh dear! 'always @(posedge clk or negedge rst_n)' block triggered with clk=0, rst_n=1.

vlt/t_vinpclk_initialisation: %Error: Exec of obj_vlt/t_vinpclk_initialisation/Vt_vinpclk_initialisation failed: Oh dear! 'always @(posedge clk or negedge rst_n)' block triggered with clk=0, rst_n=1.

#4 Updated by Wilson Snyder 4 months ago

  • Status changed from AskedReporter to Resolved
  • Assignee set to Wilson Snyder

Fixed in git towards 4.000.

As suspected randomization of VinpClk confused it. Note BTW that not getting edges at time zero is what this test expected and is the default, but the -x-initial-edge can override this behavior - that had a similar bug when randomized.

#5 Updated by Wilson Snyder 3 months ago

  • Status changed from Resolved to Closed

In 4.002.

Also available in: Atom