Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile changes cause errors #1368

Closed
veripoolbot opened this issue Nov 27, 2018 · 1 comment
Closed

Makefile changes cause errors #1368

veripoolbot opened this issue Nov 27, 2018 · 1 comment

Comments

@veripoolbot
Copy link
Collaborator


Author Name: Ian Perryman
Original Redmine Issue: 1368 from https://www.veripool.org



Hi 
I think the Makefile change 



origin/master origin/HEAD bb3814b2ced0f08a2c40c95e846cb3345ec66dcc
Author:     Wilson Snyder <wsnyder@wsnyder.org>
AuthorDate: Mon Nov 26 07:09:37 2018 -0500
Commit:     Wilson Snyder <wsnyder@wsnyder.org>
CommitDate: Mon Nov 26 07:09:37 2018 -0500


Requires an update to the README file to indicate that the EMACS environment variable must be set to the version of emacs you want to build with.


Something like this in the README file:

This is the source distribution for verilog-mode.

Please see http://www.veripool.org/verilog-mode
for more information.

  export EMACS=<path_to_emacs_binary>
  make
  make test
  cp e/verilog-mode.el <your emacs site lisp path>




Or alternately, in the Makefile, it might be better to put a conditional that would set EMACS to something sensible if the VARIABLE is undefined ... perhaps something like:

EMACS ?= emacs

Right now if you do nothing, you get errors like this:

batch -q -f batch-byte-compile e/verilog-mode.el
batch accepts no parameters
Makefile:154: recipe for target 'e/verilog-mode.elc' failed


This is because $(EMACS) is blank and the batch command is being run not emacs.

Ian

@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2018-11-27T23:03:00Z


You're right of course, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant