XML output insufficiently qualified
The xml output generated by the verilator --xmlonly command is insufficiently qualified when it comes to toplevel ports.
The attached patch addresses the issue but you need to check if it will break any of your regression tests.
#1 Updated by Wilson Snyder 5 months ago
- Status changed from New to AskedReporter
I'm fine with this concept but can you instead please update the patch to add a method to VDirection and AstVarType class similar to the existing ones there that is called by V3EmitXml? (Or perhaps verilogKwd() is sufficient.) That gets rid of the internal-peeking switch statement.
#7 Updated by Jonathan Kimmitt 4 months ago
- File xml.patch5 added
I realized too late that the patch previously submitted does not cover dumping port directions for modports. The attached fix seems to be rather simple unless you know of undesirable side-effects. Sorry for the confusion over the previous message, I did not realise your repository is not browsable.
#12 Updated by Jonathan Kimmitt 4 months ago
- File xml.patch7 added
That resolution didn't last long. It turns out AstVarXRef's are not qualified with the path of the interface that they belong to (stored in the m_dotted field). I definitely predict the rate of submission of patches will decline from now on.
#14 Updated by Jonathan Kimmitt 4 months ago
- File xml.patch8 added
It turns out the XML output does not include the display type for $display() and $write() statements and similar. As you know display has a newline at the end and write does not. This patch introduces a displaytype attribute in the XML which clarifies things and allows the original meaning to be (mostly) reconstructed. It looks like something weird is happening with the format specifiers as well, if I can figure that out a further patch might be required.
Also available in: Atom