Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++17, removed afterwards #1421

Closed
veripoolbot opened this issue Apr 29, 2019 · 4 comments
Closed

gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++17, removed afterwards #1421

veripoolbot opened this issue Apr 29, 2019 · 4 comments
Assignees
@veripoolbot
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Pieter Kapsenberg
Original Redmine Issue: 1421 from https://www.veripool.org

Original Assignee: Auto Update Daemon (@veripool-bot)

https://en.cppreference.com/w/cpp/keyword/register

Line 251:

https://en.cppreference.com/w/cpp/keyword/register
</code>

Fix is to just remove the specifier. Currently compiling with warnings on will expose this (Clang-7 at least).
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Pieter Kapsenberg
Original Date: 2019-04-29T07:54:13Z

Woops - line 251:

static unsigned LZ4_NbCommonBytes (register size_t val)
</code>

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-04-29T09:34:22Z

Pushed to git towards 4.013.

Note this file comes from GTKwave sources. I've emailed Tony Bybell to fix it, it would save a step next time to please ask GTKWave directly to fix it, then ask Verilator to pull the fix.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Pieter Kapsenberg
Original Date: 2019-04-29T09:35:58Z

Thanks Wilson. Will do for next time.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-09T01:38:06Z

In 4.014.

@veripoolbot veripoolbot added area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed labels Dec 22, 2019
@veripoolbot veripoolbot self-assigned this Dec 22, 2019
@wsnyder wsnyder mentioned this issue May 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veripoolbot veripoolbot

Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veripoolbot