Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verilator does not complain about invalid parameter declaration #1424

Closed
veripoolbot opened this issue Apr 30, 2019 · 7 comments
Closed

Verilator does not complain about invalid parameter declaration #1424

veripoolbot opened this issue Apr 30, 2019 · 7 comments
Assignees
@wsnyder
Labels
area: lint Issue involves SystemVerilog lint checking resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Peter Gerst
Original Redmine Issue: 1424 from https://www.veripool.org

Original Assignee: Wilson Snyder (@wsnyder)

Verilator fails to trow syntax error on parameter declaration without constant expression, like this:

parameter param1; /* constant expression is missing */

See the following example codes.

parameter_lint.v:

module parameter_lint (
     input wire CLK,
     input wire RST,
     input wire in0,
     output reg out0
);

parameter param0 = 0;
parameter param1;

always @(posedge CLK) begin
     if (RST) begin
         out0 <= 0;
     end else begin
         out0 <= in0;
     end
end

endmodule

parameter_main.v:

module parameter_main(
     input wire CLK,
     input wire RST,
     input wire in0,
     output reg out0
);

parameter_lint #(
     .param1 (1'd0),
     .param0 (1'd0)
) inst0 (
     .CLK (CLK),
     .RST (RST),
     .in0 (in0),
     .out0 (out0)
);

endmodule

Verilator is called in the following way:


$ verilator --lint-only -Wall parameter_main.v

The command above finishes without error. If I comment out the assignment of param1 in instantiation of parameter_lint module in parameter_main.v I get internal error.

$ verilator --lint-only -Wall parameter_main.v
%Error: Internal Error: parameter_lint.v:9: ../V3Param.cpp:277: Parameter without initial value
%Error: Internal Error: See the manual and http://www.veripool.org/verilator for more assistance.
%Error: Command Failed /usr/local/bin/verilator_bin --lint-only -Wall parameter_main.v

I used verilator release 4.012 built under cygwin.

Normally i used to call Verilator with specifying verilog 2001 language standard that needs constant expression in parameter declaration. (Xilinx syntheser i used supports this standard.) It seems to be valid for SystemVerilog 2017 as well (http://ecee.colorado.edu/~mathys/ecen2350/IntelSoftware/pdf/IEEE_Std1800-2017_8299595.pdf, page 120).
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-04-30T10:19:21Z

Parameter without initial values are legal in SystemVerilog 2017, this is not disabled when requesting earlier versions (and you request a earlier version anyhow).

I think everything is working as intended, except that the Internal Error should instead be a user error that the provided parameter was not provided (IEEE 2017 6.20.1).

Agree?

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Peter Gerst
Original Date: 2019-04-30T11:15:52Z

From the referenced documentation it seems to me that initial value can be omitted only in exceptional cases, but I must confess that I am far from an expert. :)

For my FPGA design I want to catch syntax errors and possible coding failures as soon as possible. For this I use verilator to lint sources before implementation that saves (and already saved) me lot of potential headaches.

In the demonstrated case I get syntax error from the Xilinx syntheser after a successful linting with verilator. The aim of this issue was to point this out.

More explicit I used this for linting:

$ verilator --lint-only --default-language 1364-2001 -Wall -Wno-PINCONNECTEMPTY <TOP_module>

Is it possible to add warning message for Verilog 2001? Or would it be overkill to implement this?

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-04-30T11:19:44Z

Makes sense. Will do this then:

  1. Add error when no initial value in pre-SV-2012.
  2. Otherwise, change internal error to user error.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Peter Gerst
Original Date: 2019-04-30T12:43:17Z

Sounds perfect. Thank you!

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-04-30T23:17:02Z

Fixed in git towards 4.014.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-09T01:37:26Z

In 4.014.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Peter Gerst
Original Date: 2019-05-09T07:03:25Z

It works. Thank you very much!

@veripoolbot veripoolbot added area: lint Issue involves SystemVerilog lint checking resolution: fixed Closed; fixed labels Dec 22, 2019
@wsnyder wsnyder mentioned this issue May 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsnyder wsnyder

Labels
area: lint Issue involves SystemVerilog lint checking resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsnyder @veripoolbot