New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report column numbers and source text in error messages #1435
Comments
Original Redmine Comment Are you interested in making the column/source printing change? Here's some notes. I'd think two separate patch sets, one for source printing and one for columns, probably source printing first unless only one interests you. For source printing FileLineSingleton tracks language and filename for each file letter, probably refactor that into each letter tracking a class and have the filename/language/lines as an array in that class. Then add appropriate accessors. We'd save the results out of the preprocessed code. Might need some cleanup needed in the preprocessor and elsewhere to preserve columns where it can (i.e. amount of whitespace). For columns this describes getting columns out of flex: https://stackoverflow.com/questions/656703/how-does-flex-support-bison-location-exactly we'd then spit the lex'ed columns into the FileLine and rest is easyish. |
Original Redmine Comment Sure, sign me up. However, I've got a lot of irons in the Verilator fire right now so this may take a while to get to. Also, I suspect this is related to issue #1439. So I'd like to make sure whatever I'm doing will service both issues. |
Original Redmine Comment Fixed in git towards 4.017. Also added suggestions, which are arguably even more useful.
|
Original Redmine Comment In 4.018. |
Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1435 from https://www.veripool.org
Re: Wilson's suggestion in issue #1305, we should report column numbers and source text in error messages like gcc does:
The text was updated successfully, but these errors were encountered: