Project

General

Profile

[logo] 
 
Home
News
Activity
About/Contact
Major Tools
  Dinotrace
  Verilator
  Verilog-mode
  Verilog-Perl
Other Tools
  BugVise
  CovVise
  Force-Gate-Sim
  Gspice
  IPC::Locker
  Rsvn
  SVN::S4
  Voneline
  WFH
General Info
  Papers

Issue #1438

Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy

Added by Todd Strader 8 days ago. Updated 6 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
% Done:

0%


Description

I'm using .git/info/exclude to locally ignore a directory that gets created in my Verilator repo by a code completion tool I am using. I assume it's not desirable to start adding random things like this to .gitignore so the exclude file seems like a good fit. However, t_dist_manifest.pl flags the files in this directory as "not in manifest or MANIFEST.SKIP".

I propose that this test should ignore files that are not in the distribution list and are not covered by MANIFEST.SKIP but are ignored by git. I don't "make dist", so I'm not sure about all the implications here.

See: https://github.com/toddstrader/verilator-dev/tree/manifest-from-git

History

#1 Updated by Wilson Snyder 7 days ago

  • Category set to Tests
  • Status changed from New to AskedReporter
  • Assignee set to Todd Strader

I don't like this because it ignores things like *.pdf, and forgotten PDFs are exactly the thing which this test was written to find.

I suggest you can use "git ls --ignored --exclude-from .git/info/exclude" and so only exclude personal files (not .gitignore).

BTW note there's a "nodist" intended for non-distributed work, if you have a small number of things to add to .gitignore that's fine too.

#2 Updated by Todd Strader 7 days ago

Yeah, makes sense. Let's try it this way instead: https://github.com/toddstrader/verilator-dev/tree/manifest-from-git_2

#3 Updated by Wilson Snyder 6 days ago

  • Status changed from AskedReporter to Closed

Good, pushed to git.

Made minor change to add a "cd" to make it work here & checked still works with worktree so hopefully good.

Also available in: Atom