Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy #1438

Closed
veripoolbot opened this issue May 14, 2019 · 3 comments
Closed

Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy #1438

veripoolbot opened this issue May 14, 2019 · 3 comments
Assignees
@toddstrader
Labels
area: tests Issue involves the testing system resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1438 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)

I'm using .git/info/exclude to locally ignore a directory that gets created in my Verilator repo by a code completion tool I am using. I assume it's not desirable to start adding random things like this to .gitignore so the exclude file seems like a good fit. However, t_dist_manifest.pl flags the files in this directory as "not in manifest or MANIFEST.SKIP".

I propose that this test should ignore files that are not in the distribution list and are not covered by MANIFEST.SKIP but are ignored by git. I don't "make dist", so I'm not sure about all the implications here.

See:
https://github.com/toddstrader/verilator-dev/tree/manifest-from-git
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-15T00:22:05Z

I don't like this because it ignores things like *.pdf, and forgotten PDFs are exactly the thing which this test was written to find.

I suggest you can use "git ls --ignored --exclude-from .git/info/exclude" and so only exclude personal files (not .gitignore).

BTW note there's a "nodist" intended for non-distributed work, if you have a small number of things to add to .gitignore that's fine too.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-05-15T18:48:56Z

Yeah, makes sense. Let's try it this way instead:
https://github.com/toddstrader/verilator-dev/tree/manifest-from-git_2

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-15T23:02:56Z

Good, pushed to git.

Made minor change to add a "cd" to make it work here & checked still works with worktree so hopefully good.

@veripoolbot veripoolbot added area: tests Issue involves the testing system resolution: fixed Closed; fixed labels Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toddstrader toddstrader

Labels
area: tests Issue involves the testing system resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toddstrader @veripoolbot