Project

General

Profile

[logo] 
 
Home
News
Activity
About/Contact
Major Tools
  Dinotrace
  Verilator
  Verilog-mode
  Verilog-Perl
Other Tools
  BugVise
  CovVise
  Force-Gate-Sim
  Gspice
  IPC::Locker
  Rsvn
  SVN::S4
  Voneline
  WFH
General Info
  Papers

Issue #1451

t_dist_whitespace.pl fails with --golden

Added by Todd Strader 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
% Done:

0%


Description

$ ./test_regress/t/t_dist_whitespace.pl --dist --golden
======================================================================
dist/t_dist_whitespace: ==================================================
%Warning: dist/t_dist_whitespace: Updated files with whitespace errors: include/gtkwave/lz4.c include/gtkwave/wavealloca.h
%Warning: dist/t_dist_whitespace: To auto-fix: HARNESS_UPDATE_GOLDEN=1 {command} or --golden
%Warning: dist/t_dist_whitespace: Updated whitespace at include/gtkwave/lz4.c
%Warning: dist/t_dist_whitespace: Updated whitespace at include/gtkwave/wavealloca.h
dist/t_dist_whitespace: %Error: Updated files with whitespace errors: include/gtkwave/lz4.c include/gtkwave/wavealloca.h
dist/t_dist_whitespace: FAILED: ************************************************************
==SUMMARY: Left NO-FORKER  Passed 0  Unsup 0  Skipped 0  Failed 1

The EOF whitespace test is correctly skipped for certain files such as those in the gtkwave directory. However, in --golden mode the files are flagged (even though they are not updated). Fixed here: https://github.com/toddstrader/verilator-dev/tree/whitespace-test

History

#1 Updated by Wilson Snyder 3 months ago

  • Status changed from New to Closed

Perfect, pushed to git towards 4.015.

BTW if you'd find it useful to see what of your branches have outstanding work you might want to consider for upstream complete branches, deleting your git branches and pushing the delete. See e.g. https://ardalis.com/why-delete-old-git-branches

#2 Updated by Todd Strader 3 months ago

Yeah, my only concern with deleting branches is breaking all the URLs I'm depositing here (also mentioned in the article).

Also available in: Atom