Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t_dist_whitespace.pl fails with --golden #1451

Closed
veripoolbot opened this issue May 31, 2019 · 2 comments
Closed

t_dist_whitespace.pl fails with --golden #1451

veripoolbot opened this issue May 31, 2019 · 2 comments
Assignees
@toddstrader
Labels
area: tests Issue involves the testing system resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1451 from https://www.veripool.org

Original Assignee: Todd Strader (@toddstrader)

$ ./test_regress/t/t_dist_whitespace.pl --dist --golden
======================================================================
dist/t_dist_whitespace: ==================================================
%Warning: dist/t_dist_whitespace: Updated files with whitespace errors: include/gtkwave/lz4.c include/gtkwave/wavealloca.h
%Warning: dist/t_dist_whitespace: To auto-fix: HARNESS_UPDATE_GOLDEN=1 {command} or --golden
%Warning: dist/t_dist_whitespace: Updated whitespace at include/gtkwave/lz4.c
%Warning: dist/t_dist_whitespace: Updated whitespace at include/gtkwave/wavealloca.h
dist/t_dist_whitespace: %Error: Updated files with whitespace errors: include/gtkwave/lz4.c include/gtkwave/wavealloca.h
dist/t_dist_whitespace: FAILED: ************************************************************
==SUMMARY: Left NO-FORKER  Passed 0  Unsup 0  Skipped 0  Failed 1

The EOF whitespace test is correctly skipped for certain files such as those in the gtkwave directory. However, in --golden mode the files are flagged (even though they are not updated). Fixed here:
https://github.com/toddstrader/verilator-dev/tree/whitespace-test
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-05-31T00:41:28Z

Perfect, pushed to git towards 4.015.

BTW if you'd find it useful to see what of your branches have outstanding work you might want to consider for upstream complete branches, deleting your git branches and pushing the delete. See e.g. https://ardalis.com/why-delete-old-git-branches

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Todd Strader (@toddstrader)
Original Date: 2019-05-31T09:28:56Z

Yeah, my only concern with deleting branches is breaking all the URLs I'm depositing here (also mentioned in the article).

@veripoolbot veripoolbot added area: tests Issue involves the testing system resolution: fixed Closed; fixed labels Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toddstrader toddstrader

Labels
area: tests Issue involves the testing system resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toddstrader @veripoolbot