New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document parse-order-dependency for config files #1474
Comments
Original Redmine Comment Sorry you had to experiment to figure this out (I didn't realize myself ;) but major thanks for improving the docs. Trivial really for a doc patch, but so you're set for the future, to the patch please insert your name in docs/CONTRIBUTORS to acknowledge this and future contributions are made under the Developer Certificate of Origin (https://developercertificate.org/). (Needed just once.) |
Original Redmine Comment Hi Wilson, Sorry for the slow response, looks like the email notification didn't reach me. An updated patch with a DCO Signed-off-by line is available here: https://github.com/imphil/verilator/commit/836acde22b59685a17a945d37346419ee3996523.patch And a patch adding my name to the contributors list is here: https://github.com/imphil/verilator/commit/4558efc7151bebabfd37f69b62d0764b3450ee6a.patch (Both patches are also in my note-config-parse-order branch at https://github.com/imphil/verilator.git Thanks! Philipp |
Original Redmine Comment Perfect, thanks, pushed to git towards 4.018. |
Original Redmine Comment I've hit what I think is the same issue today but can't get the waivers to apply. I'm supplying the .wlt configuration file before any Verilog files or paths. I'm using v4.016 and compiled from source. My commandline follows. Is this not the way to fix the issue? Thanks.
|
Original Redmine Comment Yes, the .vlt should be first. If you don't see suppression working please reduce it to a test case and file a new bug, thanks. |
Original Redmine Comment Creating the testcase shows me that you require an absolute path in the VLT file. Is that by design or a bug? |
Original Redmine Comment An absolute path wasn't really intended but isn't surprising since it was never thought about - would you be willing to make a new issue and try a patch, you can see preprocOpen in V3PreShell.cpp for an example of how to call filePath to resolve this. |
Original Redmine Comment Thanks, will give it a go when I have time. Cheers. |
Author Name: Philipp Wagner
Original Redmine Issue: 1474 from https://www.veripool.org
Original Assignee: Philipp Wagner
When including a .vlt configuration file with lint waivers, only the
global waivers (file == "") are applied unconditionally; all
file/line-specific waivers are only applied to files parsed after the
configuration file has been parsed.
This behavior is not documented so far (and took me some time to figure
out), so add a small note in the documentation.
Please find a patch here:
https://github.com/imphil/verilator/commit/f937318e14a454ce644645c368b415ae3ea280ec.patch
I'm not sure if you prefer to get pull requests on GitHub now, let me know and I'll do one over there.
The text was updated successfully, but these errors were encountered: