Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-faligned-new does not work under Travis with clang #1478

Closed
veripoolbot opened this issue Jul 18, 2019 · 1 comment
Closed

-faligned-new does not work under Travis with clang #1478

veripoolbot opened this issue Jul 18, 2019 · 1 comment
Labels
area: tests Issue involves the testing system effort: days Expect this issue to require roughly days of invested effort to resolve resolution: abandoned Closed; not enough information or otherwise never finished

Comments

@veripoolbot
Copy link
Contributor

Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 1478 from https://www.veripool.org

It was discovered in #� that the -faligned-new flag causes errors when compiling Verilated code under Travis CI using clang. This should have been detected and dealt with via a test for this behavior in configure, but configure did not observe the same behavior.

For the time being, a band-aid has been applied to configure.ac turn off this flag when compiling with clang under Travis:

AS_IF([test "x$TRAVIS_COMPILER" != xclang], [_MY_CXX_CHECK_OPT(CFG_CXXFLAGS_NO_UNUSED,-faligned-new)])

This resolves the Travis breakage but allows for the same issue to crop up on similar systems. Ultimately, we should understand why configure doesn't catch this behavior with Travis + clang so that the configure test can be improved and the band-aid can be removed.
@veripoolbot veripoolbot added area: tests Issue involves the testing system effort: days Expect this issue to require roughly days of invested effort to resolve labels Dec 22, 2019
@wsnyder wsnyder added the resolution: abandoned Closed; not enough information or otherwise never finished label Dec 13, 2020
@wsnyder
Copy link
Member

wsnyder commented Dec 13, 2020

We're no longer using Travis so this is unlikely to get debugged - github actions on the same OS seems to work ok. Strange.

@wsnyder wsnyder closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tests Issue involves the testing system effort: days Expect this issue to require roughly days of invested effort to resolve resolution: abandoned Closed; not enough information or otherwise never finished
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsnyder @veripoolbot