New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: VerilatedVcd callback on rolloverMB #1479
Comments
Original Redmine Comment I'm surprised there wasn't an accessor on filename() please add that regardless. Do you really need a callback? The alternative is to define your own class with whatever features are needed and inherit the existing class, and override open(). Then use that new class when creating the waves in your main(). If you need some existing functions changed to virtual (maybe openNext) that would be fine. |
Original Redmine Comment Thanks for the feedback Wilson. I could definitely make this work by inheriting VerilatedVcd with access to filename + virtual openNext(). However, unless I'm reading things wrong, I believe this will have implications on VerilatedVcdC in order to make use of it for standalone simulations. |
Original Redmine Comment I'm not sure what problem you are forseeing. Perhaps give inheriting a try? We welcome patches that result. |
Original Redmine Comment I have rebased the initial patch on top of master, sorry for posting a second patch. This patch adds a filename() getter and also allows for polymorphic use of VerilatedVcd and VerilatedVcdC. Please let me know if there are any further changes or if you would like me to take a different approach. Thanks again! |
Original Redmine Comment Good work, in general it seems fine. Please also have the patch add your name to docs/CONTRIBUTORS to acknowledge your contribution is open sourced as described there. I'd like to understand why you need to have VerilatedVcdC have a pointer to VerilatedVcd rather than just be one itself. I'm not opposed to this, but it is a bit slower and if you derive from this class it shouldn't matter. Also it's optional for this, but perhaps you want to add a test_regress test to check the polymorphic use? Otherwise what isn't tested is likely to break by accident in the future. Thanks |
This is quite old, assuming if it will be needed in the future the patch will be completed. |
Author Name: Marc Jessome
Original Redmine Issue: 1479 from https://www.veripool.org
Original Assignee: Marc Jessome
I have the time to implement this feature, and am looking for input.
This is a feature for use in conjunction with VerilatedVcd's rolloverMB functionality.
I would like to be notified when VerilatedVcd rolls over into a new file, as well as the paths to the old and new vcd file.
A few approaches that come to mind from a quick look at VerilatedVcd:
Input from maintainers on a best approach would be appreciated!
Thanks
The text was updated successfully, but these errors were encountered: