Project

General

Profile

[logo] 
 
Home
News
Activity
About/Contact
Major Tools
  Dinotrace
  Verilator
  Verilog-mode
  Verilog-Perl
Other Tools
  IPC::Locker
  Parallel::Forker
  Voneline
General Info
  Papers

Issue #1617

Assoc array adds C++11 in the codebase

Added by Todd Strader 8 days ago. Updated 8 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Configure/Make/Compiling
% Done:

0%


Description

The associative arrays commit has broken Travis: https://github.com/verilator/verilator/commit/b81295230a866e38c418349d9ed56f3a42424523

It is failing because of the C++11 code which was introduced (just <array> as far as I can tell): https://travis-ci.com/verilator/verilator/jobs/261926092

Are we officially moving to C++11 at this point, or does this commit need to be implemented for the earlier standard?

History

#1 Updated by Wilson Snyder 8 days ago

  • Subject changed from C++11 in the codebase to Assoc array adds C++11 in the codebase
  • Status changed from New to Confirmed

Sorry, that include slipped through I had added a new class instead of using array and forgot to remove the include. A later commit removed it, but then it broke for another reason.

Still not planning for C++11 as a requirement until at least mid-2020.

Committed attempted fix, leaving open till passes.

BTW, something, maybe your email-yourself?, seems to have broken the author of the commit getting email on the breakage, so I hadn't noticed. Perhaps ideal behavior would be both of us get all fails, plus the author?

#2 Updated by Wilson Snyder 8 days ago

  • Category set to Configure/Make/Compiling
  • Status changed from Confirmed to Closed
  • Assignee set to Wilson Snyder

Passed in travis, thanks for the report.

Filed bug1618 for travis "BTW" above.

Also available in: Atom