Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long if-else chain hitting MSVC's limit. #1654

Closed
veripoolbot opened this issue Dec 21, 2019 · 2 comments
Closed

Fix long if-else chain hitting MSVC's limit. #1654

veripoolbot opened this issue Dec 21, 2019 · 2 comments
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Kuba Ober
Original Redmine Issue: 1654 from https://www.veripool.org

Original Assignee: Kuba Ober

There's an if-else chain in V3Option.cpp that goes past MSVC's limit of 128 blocks. Splitting it into to parts is a low-cost workaround.

The fix is in https://github.com/KubaO/verilator/tree/feature/fix-option-chain-msvc
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Kuba Ober
Original Date: 2019-12-21T00:35:54Z

This is also #7

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2019-12-21T01:11:19Z

Thanks for the patch, makes sense. Pushed to git towards 4.026.

BTW if you have a pull request that you think completely fixes something, feel free to skip making a bug here (fine if you still want to though).

@veripoolbot veripoolbot added area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed labels Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: configure/compiling Issue involves configuring or compilating Verilator itself resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veripoolbot