New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support modules which are never used with their default parameter values #470
Comments
Original Redmine Comment If I change code to:
it still does not compile. However, if I change it to:
verilator compiles it. |
Original Redmine Comment This is because there is a division by 0 in the module before parameter expansion. At present Verilator needs "all-defaulted" pararameter version of a module to be legal; at a later stage it will realize it is never used and remove it. This will need to be fixed, which unfortunately is not a quick fix. |
Original Redmine Comment Unfortunately, this is really common in the IP code I am trying to compile with verilator, so it is not easy to hack around, unlike #� and others. In fact, I was completely stalled yesterday after trying to for several hours to modify the code - there are just too many cases of parameters with default values equal to "". One more thing to note here is that it looks like there is also always a width warning in such cases:
|
Original Redmine Comment It occurred to me that I could just not do parameter expansion on modules that aren't used and leave the eliminating of them as it is now. Fixed in git towards 3.833. |
Original Redmine Comment Thanks for the fix! This was the last issue in the IP block, although I still have to try to compile all the libraries. |
Original Redmine Comment In 3.833. |
Author Name: Alex Solomatnikov
Original Redmine Issue: 470 from https://www.veripool.org
Original Date: 2012-03-24
Original Assignee: Wilson Snyder (@wsnyder)
Code:
error:
VCS compiles this code without complaints.
The text was updated successfully, but these errors were encountered: