Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verilator does not detect if block name is used twice #485

Closed
veripoolbot opened this issue Apr 19, 2012 · 3 comments
Closed

verilator does not detect if block name is used twice #485

veripoolbot opened this issue Apr 19, 2012 · 3 comments
Labels
area: lint Issue involves SystemVerilog lint checking effort: hours Expect this issue to require roughly hours of invested effort to resolve resolution: fixed Closed; fixed type: feature-IEEE Request to add new feature, described in IEEE 1800

Comments

@veripoolbot
Copy link
Contributor

Author Name: Alex Solomatnikov
Original Redmine Issue: 485 from https://www.veripool.org
Original Date: 2012-04-19

Code:

    always_comb begin
       integer q_ind;

       for( q_ind=0; q_ind<NUM_QUEUES-1; q_ind++ ) begin: COMB
...
       for( q_ind=0; q_ind<NUM_QUEUES; q_ind++ ) begin: COMB

verilator compiles without complaint.

VCS errors out:

Error-[IPD] Identifier previously declared
  Identifier 'COMB' previously declared as NamedBlock.
  Source info:       for( q_ind=0; q_ind<NUM_QUEUES; q_ind++ ) begin: COMB
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2012-04-19T21:46:56Z

It has this warning but due to a bug misses it when under a FOR loop.

@veripoolbot veripoolbot added area: lint Issue involves SystemVerilog lint checking effort: hours Expect this issue to require roughly hours of invested effort to resolve status: blocked Issue is waiting for another bug, when other bug is fixed, then goes to 'status: assigned' type: feature-IEEE Request to add new feature, described in IEEE 1800 labels Dec 22, 2019
@ldoolitt
Copy link
Contributor

ldoolitt commented Mar 5, 2022

I turned the snippet above into a stupid little test case, attached.
issue_485.zip
The issue is indeed present with v4.010 as shipped in Debian Buster.
But the error is properly detected with v4.038 as shipped in Debian Bullseye (source date: Jul 11 2020).
Also good on several more recent versions I checked: v4.102, v4.110, v4.202, v.214, v4.216-120-g956f64c6b.
Can this be closed? Or does someone need to run the git bisect, to find the commit that fixed it?

@wsnyder wsnyder added resolution: fixed Closed; fixed and removed status: blocked Issue is waiting for another bug, when other bug is fixed, then goes to 'status: assigned' labels Aug 16, 2022
@wsnyder
Copy link
Member

wsnyder commented Aug 16, 2022

Confirm fixed.

@wsnyder wsnyder closed this as completed Aug 16, 2022
wsnyder added a commit that referenced this issue Aug 16, 2022
@wsnyder
Tests: Confirm fixed (#485)
43abaeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: lint Issue involves SystemVerilog lint checking effort: hours Expect this issue to require roughly hours of invested effort to resolve resolution: fixed Closed; fixed type: feature-IEEE Request to add new feature, described in IEEE 1800
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wsnyder @ldoolitt @veripoolbot