Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with verilog-typedef-regexp #597

Closed
veripoolbot opened this issue Dec 31, 2012 · 3 comments
Closed

Problem with verilog-typedef-regexp #597

veripoolbot opened this issue Dec 31, 2012 · 3 comments
Assignees
Labels

Comments

@veripoolbot
Copy link
Collaborator


Author Name: Andrew Hou
Original Redmine Issue: 597 from https://www.veripool.org
Original Date: 2012-12-31
Original Assignee: Wilson Snyder (@wsnyder)


Hi,

Please check the following code. The version of verilog-mode.el is 839.
The AUTO_TEMPLATE for .tm(data_tm) will be dropped.

The regexp syntax is supposed to be Perl style, and use "^t[A-Z]" to define string with prefix "t" + upper alphaset (A-Z) as type.
But .tm() seems to be treated as type, and be dropped.

If regexp "^t[AT]" is applied, the generated code is OK.
Do I miss anything?

typedef struct packed {
logic			a,b,c;
} tTest;

module test(
input		clk,rst
);

wire[7:0]	data_tm;
tTest		q;

/* foo AUTO_TEMPLATE (
.tm			(data_tm),
);
*/

foo foo (/*AUTOINST*/);
/*AUTO_LISP(setq verilog-typedef-regexp "^t[A-Z]")*/
endmodule

module foo(
input		clk,rst,
input[7:0]	tm,
tTest		q
);
endmodule
// Local Variables:
// verilog-library-directories:(".")
// End:
//


@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2012-12-31T03:45:42Z


Setting "case-fold-search: nil" will fix this but note it will affect normal manual searches also in that buffer. I will make a patch fixing this to set that for you so it doesn't affect manual searches, but need to decide if that should be the default behavior or something enabled, as it will break existing users.

@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Andrew Hou
Original Date: 2012-12-31T13:35:10Z


Thanks for the help.
It's OK for me to use regexp "^t[ABCD....Z]" for fix.
Just want to make sure no corners.

@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2015-03-13T22:39:53Z


Sorry I forgot to close this out, on Jan 2013 verilog-case-fold was added to fix this

// Local Variables:
// verilog-case-fold:nil
// End:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants