Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2013-07-29T14:38:43Z

I pushed the initialization patch.

I don't understand the class patch - what is the exact warning? According to the C++ standard, 'struct' is just a public class.

Original Redmine Comment
Author Name: Yutetsu TAKATSUKASA (@yTakatsukasa)
Original Date: 2013-07-30T12:58:12Z

Hi Wilson
Thanks for your quick response.

I agree that the class and struct are equivalent except their default accessibility.

The warning is emmitted from mismatch between actual 'definition' and 'forward declaration' generated by verilator.

Please see the attached logfile.
Note that I use my custom makefile, not generated one by verilator.
But I think you can get the same warnings if you add -CFLAGS -Wall for
verilator.

Regards,
Yutetsu.

Update:

As far as I have searched, declare as a class and define as a struct is a well-formed C++.
Only older VC++ failed to link such code.
So my class patch is not vital.

But I think enabling compiler checks (like -Wall) is useful, it actually helped me to find a potential problem (initialize patch). And fixing trivial warnings makes it easier to find non-trivial warnings.

Here is a minimal example to reproduce. (with clang-3.3)

% cat dut.v

module sub(clk, out);
     input clk;
     output out;
     reg out;
     always @(posedge clk) out <= !out;
endmodule

module top(clk, out);
     input clk;
     output out;
     sub i_sub(.clk(clk), .out(out));
endmodule

% verilator -cc -O0 -CFLAGS -Wall dut.v
% make -C obj_dir -f Vdut.mk

Thanks

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2013-08-08T23:40:06Z

Fixed other patch and some more towards 3.851.

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2013-08-15T12:46:30Z

In 3.851.