Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verilator Internal Error for shift by undef value #760

Closed
veripoolbot opened this issue May 4, 2014 · 3 comments
Closed

Verilator Internal Error for shift by undef value #760

veripoolbot opened this issue May 4, 2014 · 3 comments
Assignees
@wsnyder
Labels
resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Clifford Wolf (@cliffordwolf)
Original Redmine Issue: 760 from https://www.veripool.org
Original Date: 2014-05-04
Original Assignee: Wilson Snyder (@wsnyder)

Verilator 4a58e85 creates the following error:
"%Error: Internal Error: ../V3Number.cpp:521: toUInt with 4-state 4'bxxxx"

  input [3:0] a;
  output [3:0] y;
  assign y = a >>> 4'bx;
endmodule
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-05-04T12:53:42Z

Fixed in git towards 3.857.

I fixed this as it is easy, but in general verilator is only a two state simulator with very limited X/Z handling, so would prefer focus on non-X/Z.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Clifford Wolf (@cliffordwolf)
Original Date: 2014-05-05T11:04:36Z

Wilson Snyder wrote:

I fixed this as it is easy, but in general verilator is only a two state simulator with very limited X/Z handling, so would prefer focus on non-X/Z.

I already have a hack in place that ignores the verilator output bits that are set to X by the Yosys evaluator. Besides that it is hard to 'focus' on any specific kind of bug. For example I extracted this issue from the following test case: http://pastebin.com/UNWAmA0w (bug in y6 because p15 is undef). When generating test cases like that it is hard to avoid certain corner cases while at the same time trying to cover all the other corner cases.. ;)

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-05-11T21:11:25Z

In 3.860.

@veripoolbot veripoolbot added the resolution: fixed Closed; fixed label Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsnyder wsnyder

Labels
resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsnyder @veripoolbot