Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verilator doesn't trace code below the primitive definition within same file #837

Closed
veripoolbot opened this issue Nov 4, 2014 · 3 comments
Closed

Verilator doesn't trace code below the primitive definition within same file #837

veripoolbot opened this issue Nov 4, 2014 · 3 comments
Labels
area: wrong runtime result Issue involves an incorrect runtine result from Verilated model resolution: fixed Closed; fixed

Comments

@veripoolbot
Copy link
Contributor

Author Name: Jie Xu (@jiexu)
Original Redmine Issue: 837 from https://www.veripool.org
Original Date: 2014-11-03

For the following code, Verilator will fail to trace the module @sub_t@

module t
  (
    clk
    );

    input clk;
    integer    cyc; initial cyc = 0;

    reg a;
    reg b;
    reg z;
    sub_t sub_t_i (z, a, b);

    always @ (posedge clk) begin
       cyc <= cyc + 1;
       a <= cyc[0];
       b <= cyc[1];

       if (cyc > 10) begin
           $write("*-* All Finished *-*\n");
           $finish;
       end
    end
endmodule

primitive CINV (a, b);
output b;
input a;
assign b = ~a;
endprimitive

module sub_t (z, x, y);
input x, y;
output z;

assign z = x & y;
endmodule

The XML file says the signals in @sub_t@ are all trace_off.
@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Jie Xu (@jiexu)
Original Date: 2014-11-04T08:42:54Z

Both a test case and fix are push to my github. http://github.com/jiexu/verilator.git -b trace_primitive

The reason is because Verilator will start a @tracing_on(false)@ when @primitive@ occurs in the code. And the @tracing_on(false)@ will last to the end of that file.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-11-04T12:50:31Z

Thanks esp for a test. I fixed it slightly differently looking ahead to when/if primitives are handled better.

Fixed in git towards 3.865.

@veripoolbot
Copy link
Contributor Author

Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2014-11-15T13:46:33Z

In 3.866.

@veripoolbot veripoolbot added area: wrong runtime result Issue involves an incorrect runtine result from Verilated model resolution: fixed Closed; fixed labels Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: wrong runtime result Issue involves an incorrect runtine result from Verilated model resolution: fixed Closed; fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veripoolbot