Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labeled 'assert' is not aligned properly #905

Closed
veripoolbot opened this issue Mar 27, 2015 · 1 comment
Closed

labeled 'assert' is not aligned properly #905

veripoolbot opened this issue Mar 27, 2015 · 1 comment
Labels

Comments

@veripoolbot
Copy link
Collaborator


Author Name: Enzo Chi
Original Redmine Issue: 905 from https://www.veripool.org
Original Date: 2015-03-27
Original Assignee: Alex Reed


Got a systemverilog source code with labeled 'assert' in it like this:

RESET_VALID: assert property(SIGNAL_VALID(PRESETn));
PSEL_VALID: assert property(SIGNAL_VALID(PSEL));

After indent buffer, it becomes like this:

RESET_VALID: assert property(SIGNAL_VALID(PRESETn));
   PSEL_VALID: assert property(SIGNAL_VALID(PSEL));
@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Alex Reed
Original Date: 2015-03-27T15:11:47Z


Thanks for the report. I'm going to assume you're using the latest released version (2015-03-13-7ee11f6-vpo) or possibly even the latest revision posted on github (951f48b).


This regression was partially introduced in d05c01d. This affects subsequent named assertions after "@Property p ... endproperty: p@" (i.e. if you have 2+ named assertions immediately after a labeled endproperty, then the first assertion is indented correctly but the rest are not.). Interestingly, if the first assertion is not labeled, then subsequent assertions (labeled or not) are also indented incorrectly. This appears to have existed for quite some time (possibly always?). If you remove the "@: p@" from the "@endproperty@", things seem to be okay.



Root cause is related to the parser seeing "@endproperty : p@" and thinking it looks like "@:@".



I have updated an existing test-case and patched verilog-mode.el. You may grab the latest version from https://github.com/veripool/verilog-mode or wait for a new release on http://www.veripool.org/projects/verilog-mode/wiki/Installing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant