Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser issue with empty ports #97

Closed
veripoolbot opened this issue Jun 11, 2009 · 2 comments
Closed

Parser issue with empty ports #97

veripoolbot opened this issue Jun 11, 2009 · 2 comments
Assignees

Comments

@veripoolbot
Copy link
Collaborator


Author Name: Noam Meir
Original Redmine Issue: 97 from https://www.veripool.org
Original Date: 2009-06-11
Original Assignee: Wilson Snyder (@wsnyder)


Hello,
As discussed earleir with Wilson, found a bug in the Parser,
description:
when using the following code (notice the ',' after lastPort) the parser gives a syntax error:

Module my_module(
portA,
portB,
.
.
.
lastPort, );

the spec says:
list_of_ports ::= '(' port { ',' port } ')'
port ::= [ port_expression ]

So that's actually legal. However it doesn't do what you
think, as it defines another port that's empty that should
be connected if doing position based interconnection, so
really your code should be fixed as I doubt that's ever the
intent.

I think that the best way to resolve this issue is not to let it pass by, but to give a warning about it since it is definetly bad coding that might cause troubles.

@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2009-06-14T11:36:08Z


This is fixed in the GIT version and will be in the next release. Thanks.

@veripoolbot
Copy link
Collaborator Author


Original Redmine Comment
Author Name: Wilson Snyder (@wsnyder)
Original Date: 2009-06-17T12:01:37Z


In 3.211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants