New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improperly width'ed default function argument shouldn't error out #984
Comments
Original Redmine Comment Probably missing a call to constify somewhere. Would you like to try a patch? |
Original Redmine Comment Yeah, sure thing. It may take me a little longer to get to this one, but it's on the list. |
Original Redmine Comment Took a quick look at this. It seems the problem stems from that V3Width converts the constant to SEL\CONST\CONST\CONST, then V3Width calls V3Task::taskConnects which barfs on the SEL (Expecting const). The quick fix of attempting to call V3Const results in an infinte loop as V3Const calls into V3Width. There might still be a quick fix but not as obvious as expected from the ticket. |
Original Redmine Comment Trivial fix it seems:
passes all tests including the one attached to this ticket. |
Original Redmine Comment Thanks for the patch! Fixed in git towards 3.902. |
Original Redmine Comment In 3.902. |
Author Name: Todd Strader (@toddstrader)
Original Redmine Issue: 984 from https://www.veripool.org
https://github.com/toddstrader/verilator-dev/tree/default_arg
I would expect a WIDTH warning instead. Also, the current error message is a bit confusing:
The text was updated successfully, but these errors were encountered: