Verilator

05/12/2019

07:56 PM Issue #1305: Error messages do not contain hierarchical information

1. I don't think you should attach scopeName to modules. A module may have many uses at different scopes. Instead, l... Wilson Snyder

12:20 PM Issue #1433 (Resolved): Warnings from unused parameters in verilated_fst_c.h

Wall done. I also passed set_time_resolution call down to the VerilatedFst class which would be needed if we ever get... Wilson Snyder

05:01 AM Issue #1433: Warnings from unused parameters in verilated_fst_c.h

I have attached a patch file that adds the cast to the ... Pieter Kapsenberg

02:54 AM Issue #1433 (Closed): Warnings from unused parameters in verilated_fst_c.h

In my current project I get some warnings from unused parameters. Since this in the FST header, it gets pulled into m... Pieter Kapsenberg

05/10/2019

01:35 PM Issue #1305: Error messages do not contain hierarchical information

Here's the rest (actual error location reporting) which has been rebased onto upstream:
https://github.com/toddstrad... Todd Strader

12:03 AM Issue #1305: Error messages do not contain hierarchical information

v3number_hier_2 is pushed to git, just cleaned up some spacing and names, thanks for this.
Wilson Snyder

12:30 AM Issue #1326 (NotEnoughInfo): Comb Logic order problem

Didn't get more information - if you have more to go on please post.
Wilson Snyder

12:29 AM Issue #1407 (NotEnoughInfo): facing a error for verilatedvcdsc

Didn't hear back & presume you got it working. If you have tips to post for others that hit similar issues please upd... Wilson Snyder

12:28 AM Issue #1351 (WillNotFix): Support for loading stimulus from VCD file

VCD stimulus applying isn't really directly related to Verilator, and unlikely would get to do this in the forseeable... Wilson Snyder

05/09/2019

11:25 PM Issue #1408 (WillNotFix): Support concatenation select

As earlier commented, not supported by big simulators, so not fixing for now; if the others support this will revisit.
Wilson Snyder

07:03 AM Issue #1424: Verilator does not complain about invalid parameter declaration

It works. Thank you very much! Peter Gerst

01:37 AM Issue #1424 (Closed): Verilator does not complain about invalid parameter declaration

In 4.014.
Wilson Snyder

01:38 AM Issue #1431 (Closed): Multiple local variables with the same name ( __Vtable1_valid ) generated i...

In 4.014.
Wilson Snyder

01:38 AM Issue #1426 (Closed): enum logic[2:0] not generating enum in fst file

In 4.014.
Wilson Snyder

01:38 AM Issue #1421 (Closed): gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++...

In 4.014.
Wilson Snyder

01:38 AM Issue #1417 (Closed): FST regression tests fail instead of skip if fst2vcd isn't installed

In 4.014.
Wilson Snyder

01:37 AM Issue #1413 (Closed): Wrong printf/scanf format specifiers used for MinGW targets

In 4.014.
Wilson Snyder

01:37 AM Issue #1415 (Closed): Verilator generates calls to an undefined function named: VL_SHIFTR_QQW

In 4.014.
Wilson Snyder

01:37 AM Issue #1412 (Closed): Verilator generates calls to an undefined function named: VL_SHIFTL_QQW

In 4.014.
Wilson Snyder

01:37 AM Issue #1423 (Closed): 2 issues with unsized x/z constants

In 4.014.
Wilson Snyder

01:37 AM Issue #1411 (Closed): # comments support in .mem files

In 4.014.
Wilson Snyder

01:36 AM Verilator 4.014 Released

Verilator 4.014 2019-05-08
*** Add --trace-fst-thread.
**** Support '#' comments in $readmem, bug1411. [Fred... Wilson Snyder

05/08/2019

11:11 AM Issue #1305: Error messages do not contain hierarchical information

The v3number patches look reasonable. Tonight (ish) I'll push a release, then apply this with some spacing fixes.
Wilson Snyder

01:59 AM Issue #1423 (Resolved): 2 issues with unsized x/z constants

X/Z extension fixed with warning in git towards 4.014.
Wilson Snyder

05/07/2019

06:27 PM Issue #1305: Error messages do not contain hierarchical information

I've rebased onto master and taken care of the above:
https://github.com/toddstrader/verilator-dev/tree/v3number_hie... Todd Strader

07:35 AM Issue #1430: Broken node on indexed interface modport

The usual command line, as stated in the attached logfile: verilator -cc --top-module ariane_testharness --debug --gd... Jonathan Kimmitt

05/06/2019

11:34 PM Issue #1431 (Resolved): Multiple local variables with the same name ( __Vtable1_valid ) generated...

Thanks for the good test. Bug in the table code which BTW can be disabled with -Ot.
Fixed in git towards 4.014.
Wilson Snyder

02:03 PM Issue #1431 (Closed): Multiple local variables with the same name ( __Vtable1_valid ) generated i...

Hi,
I've stumbled upon a situation where verilator generates invalid C++ code, i.e. it generates multiple local va... Bogdan Vukobratovic

10:42 PM Issue #1430: Broken node on indexed interface modport

What command line are you using? Can you please check with the most recent version? If that fails, a reduced test c... Wilson Snyder

01:46 PM Issue #1430: Broken node on indexed interface modport

If the entire (preprocessed) design is acceptable as a testcase, please find it attached.
Jonathan Kimmitt

12:33 PM Issue #1430 (AskedReporter): Broken node on indexed interface modport

The line before "Internal Error" should have been an error about node 66ade10
3:1: IFACEREFDTYPE 0x66ade10 <e1... Wilson Snyder

09:01 AM Issue #1430 (AskedReporter): Broken node on indexed interface modport

... Jonathan Kimmitt

05/04/2019

01:37 AM Issue #1305: Error messages do not contain hierarchical information

All the different AstConst constructor flavors with V3NumberConstructor are just the
>different flavors of V3Number ... Wilson Snyder

05/03/2019

02:21 PM Issue #1305: Error messages do not contain hierarchical information

I've updated this branch based on the items below:
https://github.com/toddstrader/verilator-dev/tree/v3number_hier
... Todd Strader

07:14 AM Issue #1429: Feature request: elaboration tasks

OK, I tried looking into it.
From the XML I see that the $info/$warning etc. in a function are put directly inside t... Udi Finkelstein

12:30 AM Issue #1429: Feature request: elaboration tasks

I'm less familiar with the Verilator codebase, but I';ll try next week.
In the meantime, I've worked on:
https://gi... Udi Finkelstein

05/02/2019

11:45 PM Issue #1305: Error messages do not contain hierarchical information

Golden file is committed.
V3Number comments:
>+ AstConst(FileLine* fl, V3NumberConstructor)
I could puzzl... Wilson Snyder

06:31 PM Issue #1305: Error messages do not contain hierarchical information

The V3Number refactor is isolated here:
https://github.com/toddstrader/verilator-dev/tree/v3number_hier
And the g... Todd Strader

06:02 PM Issue #1305: Error messages do not contain hierarchical information

I'm juggling git commits now. In the meantime, I've got this to survey other tools' error messages:
https://www.eda... Todd Strader

08:36 PM Issue #1427: Incorrect real parameter assignment

Almost done, but still a WIP:
https://github.com/toddstrader/verilator-dev/tree/broken_real_param2
Using a <V3Has... Todd Strader

03:49 PM Issue #1427: Incorrect real parameter assignment

>Which makes sense because as far as I can tell, V3Hash is just doing some pointer munging on nodep
I had forgotte... Wilson Snyder

03:25 PM Issue #1427: Incorrect real parameter assignment

Multiple follow-up questions:
> I think what you can do is always use V3Hash of the node (not node's name) so tha... Todd Strader

07:51 PM Issue #1429: Feature request: elaboration tasks

As you noted this is (supposedly) supported, can you please edit the e.g. test_regress/t/t_assert_elab_bad.pl test to... Wilson Snyder

06:43 PM Issue #1429: Feature request: elaboration tasks

Searching a github copy of verilator for completely different stuff ($diplay() implementations), I hit upon the Veril... Udi Finkelstein

01:40 PM Issue #1429: Feature request: elaboration tasks

Sorry, no way to edit posts :-(
The text above is obviously taken from the IEEE1800-2017 LRM.
This is the test ... Udi Finkelstein

01:38 PM Issue #1429 (Resolved): Feature request: elaboration tasks

While looking for a way to trigger an error on invalid parameter combinations of a parammetrized module, I stumbled u... Udi Finkelstein

12:03 AM Issue #1423 (Confirmed): 2 issues with unsized x/z constants

"'dx" was accidentally unsupported, fixed this in git towards 4.014.
The extension to match the spec I'll look at.... Wilson Snyder

05/01/2019

11:49 PM Issue #1305: Error messages do not contain hierarchical information

Oh, also please merge from upstream; I merged your MANIFEST.SKIP change.
Wilson Snyder

11:46 PM Issue #1305: Error messages do not contain hierarchical information

I'm finding this is a little massive, can you peel off the V3Number-node stuff into a subpatch I can review/apply fir... Wilson Snyder

11:18 PM Issue #1426 (Resolved): enum logic[2:0] not generating enum in fst file

Thanks for the report, fixed in git towards 4.014.
Wilson Snyder

02:38 PM Issue #1426 (Closed): enum logic[2:0] not generating enum in fst file

Hi Wilson.
When declaring an enum as:
typedef enum logic[1:0] { ZERO=0, ONE, TWO, THREE } enumed_t; // Not wor... Danilo Ramos

10:32 PM Issue #1425 (WillNotFix): Sensitivity lists with boolean expressions

Verilator doesn't really do anything with sensitivity lists except posedge/negedge handling; it basically is followin... Wilson Snyder

11:57 AM Issue #1425 (WillNotFix): Sensitivity lists with boolean expressions

Items in sensitivity lists can be expressions:... Al Grant

10:27 PM Issue #1427 (Assigned): Incorrect real parameter assignment

The duplicate nodes are because the values are being evaluated in the loop and previously deleted nodes reused. I sup... Wilson Snyder

05:31 PM Issue #1427: Incorrect real parameter assignment

So I found one of the cases above that I was speculating about. I haven't fully determined why, but there are cases ... Todd Strader

02:40 PM Issue #1427 (Closed): Incorrect real parameter assignment

See here for the test and a possible fix:
https://github.com/toddstrader/verilator-dev/tree/broken_real_param
The... Todd Strader

04/30/2019

11:17 PM Issue #1424 (Resolved): Verilator does not complain about invalid parameter declaration

Fixed in git towards 4.014.
Wilson Snyder

12:43 PM Issue #1424: Verilator does not complain about invalid parameter declaration

Sounds perfect. Thank you! Peter Gerst

11:19 AM Issue #1424 (Confirmed): Verilator does not complain about invalid parameter declaration

Makes sense. Will do this then:
1. Add error when no initial value in pre-SV-2012.
2. Otherwise, change internal er... Wilson Snyder

11:15 AM Issue #1424: Verilator does not complain about invalid parameter declaration

From the referenced documentation it seems to me that initial value can be omitted only in exceptional cases, but I m... Peter Gerst

10:19 AM Issue #1424 (AskedReporter): Verilator does not complain about invalid parameter declaration

Parameter without initial values are legal in SystemVerilog 2017, this is not disabled when requesting earlier versio... Wilson Snyder

09:51 AM Issue #1424 (Closed): Verilator does not complain about invalid parameter declaration

Verilator fails to trow syntax error on parameter declaration without constant expression, like this:... Peter Gerst

08:25 AM Issue #1423 (Closed): 2 issues with unsized x/z constants

Verilator is complaining about this code snippet, even if SV mode:... Udi Finkelstein

04/29/2019

09:36 AM Issue #1422 (Feature): VPI hierarchy naming

I agree 3 makes the most sense. Perhaps the TOP should also be suppressed in %m messages, that is it will look to ru... Wilson Snyder

08:38 AM Issue #1422 (NoFixNeeded): VPI hierarchy naming

Hi,
I am currently looking into coupling cocotb and Verilator and stumbled over one major issue, that can be solve... Stefan Wallentowitz

09:35 AM Issue #1421: gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++17, remov...

Thanks Wilson. Will do for next time. Pieter Kapsenberg

09:34 AM Issue #1421 (Resolved): gtkwave/lz4.c uses the "register" storage class, which is deprecated in C...

Pushed to git towards 4.013.
Note this file comes from GTKwave sources. I've emailed Tony Bybell to fix it, it wo... Wilson Snyder

07:54 AM Issue #1421: gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++17, remov...

Woops - line 251:... Pieter Kapsenberg

07:53 AM Issue #1421 (Closed): gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++...

https://en.cppreference.com/w/cpp/keyword/register
Line 251:... Pieter Kapsenberg

04/28/2019

11:49 PM Issue #1363: CMake support

Any movement on this Patrick? CMake is pretty popular, getting this in would make it so much easier to use Verilator ... Pieter Kapsenberg

09:54 PM Issue #1419 (Closed): --trace-fst documentation issue

Pushed to git, thanks.
Wilson Snyder

04/23/2019

05:29 PM Issue #1305: Error messages do not contain hierarchical information

I seem to have worked myself into a corner and therefore have backtracked a bit. I believe/hope this branch is ready... Todd Strader

04/17/2019

11:56 PM Issue #1305: Error messages do not contain hierarchical information

Nodes don't exist in the lexer. I suppose we cold make fake temp nodes, but don't like this as some alternative futur... Wilson Snyder

04:28 PM Issue #1305: Error messages do not contain hierarchical information

Another question: it seems that there are quite a few _bad tests that are still using *expect* regexes instead of *ex... Todd Strader

04/16/2019

09:48 PM Issue #1419 (Closed): --trace-fst documentation issue

Small documentation fix:
https://github.com/toddstrader/verilator-dev/tree/fst-doc-fix Todd Strader

04:26 PM Issue #1305: Error messages do not contain hierarchical information

I've posted the latest changes here:
https://github.com/toddstrader/verilator-dev/tree/mod_stack_trace
This now a... Todd Strader

04/15/2019

02:26 PM Issue #1418: Having trouble assigning signals of interfaces to regs within for loop

Hi Wilson,
We come across a Xilinx page that suggests having for loop inside always_comb helps to save runtime.
h... Junyi Xie