![[logo]](/img/veripool_small.png)
Activity
From 04/22/2019 to 05/21/2019
05/21/2019
- 02:14 PM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
- Great, fix confirmed, thanks.
One very minor observation. For consistency with other simulators, could we suffix %...
05/18/2019
- 12:51 AM Issue #1427 (Resolved): Incorrect real parameter assignment
- Pushed to git towards 4.015. Just replaced two minor C++11 isms.
Thanks again for the work.
05/17/2019
- 10:27 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- From https://www.liquid-technologies.com/xml/escapingdata.aspx
says you can character escape unicode format in dec... - 09:45 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Do you mean U+0005 control character? My understanding is that it is not allowed in XML 1.0 [https://en.wikipedia.org...
- 09:37 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Please add a \005 to the test and I suspect you'll see we need to also ampersand-number quote non-ascii similar to th...
- 06:54 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Patch for the fix is attached. Includes test update.
- 01:41 AM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- 0001 looks good, I just changed some spacing to bring up to newer standard (no tabs). Pushed to git in 4.015.
- 08:54 PM Issue #1427: Incorrect real parameter assignment
- Thanks again for the feedback. I've updated the branch to reflect all of this:
https://github.com/toddstrader/veril... - 10:52 AM Issue #1427: Incorrect real parameter assignment
- I looked through and am a bit fuzzy on why interfaces are handled this way. I think the idea is that each parameteriz...
- 08:41 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- OS & compiler used in report:
* Linux Ubuntu 16.04
* gcc 5.4
URL to reference data/project somehow was lost as... - 08:36 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- Comparing configure vs. CMAKE (details see attached file):
* systemc 2.3.3 build via configure is producing correc... - 01:22 AM Issue #1441 (Resolved): incorrect handling of strings in display and sformatf
- Both issues fixed in git towards 4.015.
05/16/2019
- 11:39 PM Issue #1443 (Resolved): Calling $display with real %t argument causes segfault in _vl_vsformat
- Thanks for the test case.
Basically %t didn't support real numbers ($realtime).
Fixed in git towards 4.015.
- 03:44 PM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
- The segfault seems to be dependent upon the %t time format output, and the call to $realtime also being present.
W... - 03:37 PM Issue #1443 (Closed): Calling $display with real %t argument causes segfault in _vl_vsformat
- Standalone minimal test case attached
Output running executable under GDB:
TestCase at 1 this is fine
TestCase... - 10:56 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- First patch to relocate quoteNameControls function from V3Number to V3OutFormatter is attached.
Please let me know... - 06:46 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Thanks for taking this on & asking.
V3Number::quoteNameControls really is in the wrong place, I would suggest firs... - 04:42 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- I can work on a fix. What I am not sure is whether
* Add language argument to V3Number::quoteNameControls function
... - 04:37 PM Issue #1444 (Confirmed): Invalid xml output generated when code contains functions with string ar...
- Your diagnosis sounds reasonable, perhaps you could provide a patch? Probably V3File's OutFormatter is the right spo...
- 03:47 PM Issue #1444 (Closed): Invalid xml output generated when code contains functions with string argum...
- For the attached code (topmod.sv), verilator (4.014) is generating invalid xml output (attached Vtopmod.xml).
The ... - 10:43 PM Issue #1427: Incorrect real parameter assignment
- Great, thanks for the feedback. I haven't had any more time to look at this once since I last posted, so I'm still c...
- 10:13 PM Issue #1427: Incorrect real parameter assignment
- Sorry, forgot this one needed reply.
On a collision not reusing sounds fine, I'd keep new one.
For collision te... - 09:55 PM Issue #1445 (AskedReporter): simple sample doesn't poduce trace when using systemc 2.3
- Sounds same as bug1307. I use 2.3.3 for all testing and do not see this problem, if you can figure it out please pos...
- 04:32 PM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- This may be same problem as Issue #1307, since I build SystemC 2.3.3 with CMAKE.
- 04:25 PM Issue #1445 (NoFixNeeded): simple sample doesn't poduce trace when using systemc 2.3
* Verilator version used: 4.015
* SystemC built on Linux from original reference sources by accelera.org
* There ...- 01:58 AM Issue #1441 (Confirmed): incorrect handling of strings in display and sformatf
- Thanks for putting this in test_regress format, that helps.
First bug is at present it assumes %h when no display ... - 01:44 AM Issue #1442 (Confirmed): Enum value not made sized when enum sized
- I suspect you added the LEN casts to try to work around this, but note they are unnecessary to show the problem, whic...
- 12:50 AM Issue #1442: Enum value not made sized when enum sized
- Verilator 4.015 devel rev UNKNOWN_REV
- 12:48 AM Issue #1442: Enum value not made sized when enum sized
- $ verilator --lint-only test.v
%Warning-WIDTHCONCAT: test.v:8:
Unsized numbers/parameters not allowed in conc... - 12:38 AM Issue #1442 (Resolved): Enum value not made sized when enum sized
- ...
05/15/2019
- 11:02 PM Issue #1438 (Closed): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- Good, pushed to git.
Made minor change to add a "cd" to make it work here & checked still works with worktree so h... - 06:48 PM Issue #1438: Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- Yeah, makes sense. Let's try it this way instead:
https://github.com/toddstrader/verilator-dev/tree/manifest-from-g... - 12:22 AM Issue #1438 (AskedReporter): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- I don't like this because it ignores things like *.pdf, and forgotten PDFs are exactly the thing which this test was ...
- 02:51 PM Issue #1441 (Closed): incorrect handling of strings in display and sformatf
- $display of a string parameter or an expression with type string produces incorrect result in certain cases.
Please ... - 12:52 AM Issue #1440: V3Ast.cpp gives warning with -Winvalid-noreturn
- Awesome, thanks for the clarification!
- 12:52 AM Issue #1440: V3Ast.cpp gives warning with -Winvalid-noreturn
- Pushed to git towards 4.016.
- 12:51 AM Issue #1440 (Closed): V3Ast.cpp gives warning with -Winvalid-noreturn
- Your fix looks good, there were also two other similar sections of code I patched.
The assert will never get hit, ...
05/14/2019
- 10:17 PM Issue #1440 (Closed): V3Ast.cpp gives warning with -Winvalid-noreturn
- Compiling src/V3Ast.cpp produces the following warning when compiled with -Winvalid-noreturn (Apple LLVM version 10.0...
- 09:53 PM Issue #1435: Report column numbers and source text in error messages
- Sure, sign me up. However, I've got a lot of irons in the Verilator fire right now so this may take a while to get t...
- 09:51 PM Issue #1439 (Closed): Add "included from" and macro expansion information in error messages
- Ideally Verilator would report messages similar to gcc in these scenarios. Something like this:...
- 09:04 PM Issue #1305: Error messages do not contain hierarchical information
- Inlining is a bummer wrt to this issue. It seems like we'd have to possibly tag every node with a scope name before ...
- 08:53 PM Issue #1438 (Closed): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- I'm using .git/info/exclude to locally ignore a directory that gets created in my Verilator repo by a code completion...
- 10:51 AM Issue #1436 (Resolved): Add an option to silence the command-failed message
- Thanks for updating. Pushed to git towards 4.016.
- 09:40 AM Issue #1436: Add an option to silence the command-failed message
- Updated at:
https://github.com/toddstrader/verilator-dev/tree/quiet_error - 10:35 AM Issue #1437 (Resolved): -Wsign-compare warning in verilated.cpp
- Well done, thanks for the good work.
Fixed in git towards 4.016.
- 07:16 AM Issue #1437 (Closed): -Wsign-compare warning in verilated.cpp
- I do not use verilated.mk to compile the generated C++ code, and I get these warnings (CFLAGS = -Wall -Wextra)
...
05/13/2019
- 11:32 PM Issue #1305: Error messages do not contain hierarchical information
- Please pull from master and see test_regress/t/t_param_scope_bad and test_regress/t/t_clk_scope_bad
These are exam... - 06:16 PM Issue #1305: Error messages do not contain hierarchical information
- > 1. I don't think you should attach scopeName to modules.
I presume we're talking about m_hierName. Is this real... - 10:46 PM Issue #1435 (Feature): Report column numbers and source text in error messages
- Are you interested in making the column/source printing change? Here's some notes.
I'd think two separate patch s... - 06:19 PM Issue #1435 (Resolved): Report column numbers and source text in error messages
- Re: Wilson's suggestion in issue #1305, we should report column numbers and source text in error messages like gcc do...
- 10:36 PM Issue #1436 (Feature): Add an option to silence the command-failed message
- Seems reasonable. Please two things then will merge, 1. need documentation for flag (you did summary but not the lar...
- 09:58 PM Issue #1436 (Closed): Add an option to silence the command-failed message
- Often times my command line invocation of Verilator is so large that this pushes the actual error message off the scr...
- 04:05 PM Issue #1434 (NoFixNeeded): systemverilog Scoped types in enums support
- You're referencing "T::" e.g. package T, but have not declared it as required by IEEE.
I suspect what you want is ... - 03:42 PM Issue #1434 (NoFixNeeded): systemverilog Scoped types in enums support
- ...
05/12/2019
- 07:56 PM Issue #1305: Error messages do not contain hierarchical information
- 1. I don't think you should attach scopeName to modules. A module may have many uses at different scopes. Instead, l...
- 12:20 PM Issue #1433 (Resolved): Warnings from unused parameters in verilated_fst_c.h
- Wall done. I also passed set_time_resolution call down to the VerilatedFst class which would be needed if we ever get...
- 05:01 AM Issue #1433: Warnings from unused parameters in verilated_fst_c.h
- I have attached a patch file that adds the cast to the ...
- 02:54 AM Issue #1433 (Closed): Warnings from unused parameters in verilated_fst_c.h
- In my current project I get some warnings from unused parameters. Since this in the FST header, it gets pulled into m...
05/10/2019
- 01:35 PM Issue #1305: Error messages do not contain hierarchical information
- Here's the rest (actual error location reporting) which has been rebased onto upstream:
https://github.com/toddstrad... - 12:03 AM Issue #1305: Error messages do not contain hierarchical information
- v3number_hier_2 is pushed to git, just cleaned up some spacing and names, thanks for this.
- 12:30 AM Issue #1326 (NotEnoughInfo): Comb Logic order problem
- Didn't get more information - if you have more to go on please post.
- 12:29 AM Issue #1407 (NotEnoughInfo): facing a error for verilatedvcdsc
- Didn't hear back & presume you got it working. If you have tips to post for others that hit similar issues please upd...
- 12:28 AM Issue #1351 (WillNotFix): Support for loading stimulus from VCD file
- VCD stimulus applying isn't really directly related to Verilator, and unlikely would get to do this in the forseeable...
05/09/2019
- 11:25 PM Issue #1408 (WillNotFix): Support concatenation select
- As earlier commented, not supported by big simulators, so not fixing for now; if the others support this will revisit.
- 07:03 AM Issue #1424: Verilator does not complain about invalid parameter declaration
- It works. Thank you very much!
- 01:37 AM Issue #1424 (Closed): Verilator does not complain about invalid parameter declaration
- In 4.014.
- 01:38 AM Issue #1431 (Closed): Multiple local variables with the same name ( __Vtable1_valid ) generated i...
- In 4.014.
- 01:38 AM Issue #1426 (Closed): enum logic[2:0] not generating enum in fst file
- In 4.014.
- 01:38 AM Issue #1421 (Closed): gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++...
- In 4.014.
- 01:38 AM Issue #1417 (Closed): FST regression tests fail instead of skip if fst2vcd isn't installed
- In 4.014.
- 01:37 AM Issue #1413 (Closed): Wrong printf/scanf format specifiers used for MinGW targets
- In 4.014.
- 01:37 AM Issue #1415 (Closed): Verilator generates calls to an undefined function named: VL_SHIFTR_QQW
- In 4.014.
- 01:37 AM Issue #1412 (Closed): Verilator generates calls to an undefined function named: VL_SHIFTL_QQW
- In 4.014.
- 01:37 AM Issue #1423 (Closed): 2 issues with unsized x/z constants
- In 4.014.
- 01:37 AM Issue #1411 (Closed): # comments support in .mem files
- In 4.014.
- 01:36 AM Verilator 4.014 Released
- Verilator 4.014 2019-05-08
*** Add --trace-fst-thread.
**** Support '#' comments in $readmem, bug1411. [Fred...
05/08/2019
- 11:11 AM Issue #1305: Error messages do not contain hierarchical information
- The v3number patches look reasonable. Tonight (ish) I'll push a release, then apply this with some spacing fixes.
- 01:59 AM Issue #1423 (Resolved): 2 issues with unsized x/z constants
- X/Z extension fixed with warning in git towards 4.014.
05/07/2019
- 06:27 PM Issue #1305: Error messages do not contain hierarchical information
- I've rebased onto master and taken care of the above:
https://github.com/toddstrader/verilator-dev/tree/v3number_hie... - 07:35 AM Issue #1430: Broken node on indexed interface modport
- The usual command line, as stated in the attached logfile: verilator -cc --top-module ariane_testharness --debug --gd...
05/06/2019
- 11:34 PM Issue #1431 (Resolved): Multiple local variables with the same name ( __Vtable1_valid ) generated...
- Thanks for the good test. Bug in the table code which BTW can be disabled with -Ot.
Fixed in git towards 4.014.
- 02:03 PM Issue #1431 (Closed): Multiple local variables with the same name ( __Vtable1_valid ) generated i...
- Hi,
I've stumbled upon a situation where verilator generates invalid C++ code, i.e. it generates multiple local va... - 10:42 PM Issue #1430: Broken node on indexed interface modport
- What command line are you using? Can you please check with the most recent version? If that fails, a reduced test c...
- 01:46 PM Issue #1430: Broken node on indexed interface modport
- If the entire (preprocessed) design is acceptable as a testcase, please find it attached.
- 12:33 PM Issue #1430 (AskedReporter): Broken node on indexed interface modport
- The line before "Internal Error" should have been an error about node 66ade10
3:1: IFACEREFDTYPE 0x66ade10 <e1... - 09:01 AM Issue #1430 (AskedReporter): Broken node on indexed interface modport
- ...
05/04/2019
- 01:37 AM Issue #1305: Error messages do not contain hierarchical information
- All the different AstConst constructor flavors with V3NumberConstructor are just the
>different flavors of V3Number ...
05/03/2019
- 02:21 PM Issue #1305: Error messages do not contain hierarchical information
- I've updated this branch based on the items below:
https://github.com/toddstrader/verilator-dev/tree/v3number_hier
... - 07:14 AM Issue #1429: Feature request: elaboration tasks
- OK, I tried looking into it.
From the XML I see that the $info/$warning etc. in a function are put directly inside t... - 12:30 AM Issue #1429: Feature request: elaboration tasks
- I'm less familiar with the Verilator codebase, but I';ll try next week.
In the meantime, I've worked on:
https://gi...
05/02/2019
- 11:45 PM Issue #1305: Error messages do not contain hierarchical information
- Golden file is committed.
V3Number comments:
>+ AstConst(FileLine* fl, V3NumberConstructor)
I could puzzl... - 06:31 PM Issue #1305: Error messages do not contain hierarchical information
- The V3Number refactor is isolated here:
https://github.com/toddstrader/verilator-dev/tree/v3number_hier
And the g... - 06:02 PM Issue #1305: Error messages do not contain hierarchical information
- I'm juggling git commits now. In the meantime, I've got this to survey other tools' error messages:
https://www.eda... - 08:36 PM Issue #1427: Incorrect real parameter assignment
- Almost done, but still a WIP:
https://github.com/toddstrader/verilator-dev/tree/broken_real_param2
Using a <V3Has... - 03:49 PM Issue #1427: Incorrect real parameter assignment
- >Which makes sense because as far as I can tell, V3Hash is just doing some pointer munging on nodep
I had forgotte... - 03:25 PM Issue #1427: Incorrect real parameter assignment
- Multiple follow-up questions:
> I think what you can do is always use V3Hash of the node (not node's name) so tha... - 07:51 PM Issue #1429: Feature request: elaboration tasks
- As you noted this is (supposedly) supported, can you please edit the e.g. test_regress/t/t_assert_elab_bad.pl test to...
- 06:43 PM Issue #1429: Feature request: elaboration tasks
- Searching a github copy of verilator for completely different stuff ($diplay() implementations), I hit upon the Veril...
- 01:40 PM Issue #1429: Feature request: elaboration tasks
- Sorry, no way to edit posts :-(
The text above is obviously taken from the IEEE1800-2017 LRM.
This is the test ... - 01:38 PM Issue #1429 (Resolved): Feature request: elaboration tasks
- While looking for a way to trigger an error on invalid parameter combinations of a parammetrized module, I stumbled u...
- 12:03 AM Issue #1423 (Confirmed): 2 issues with unsized x/z constants
- "'dx" was accidentally unsupported, fixed this in git towards 4.014.
The extension to match the spec I'll look at....
05/01/2019
- 11:49 PM Issue #1305: Error messages do not contain hierarchical information
- Oh, also please merge from upstream; I merged your MANIFEST.SKIP change.
- 11:46 PM Issue #1305: Error messages do not contain hierarchical information
- I'm finding this is a little massive, can you peel off the V3Number-node stuff into a subpatch I can review/apply fir...
- 11:18 PM Issue #1426 (Resolved): enum logic[2:0] not generating enum in fst file
- Thanks for the report, fixed in git towards 4.014.
- 02:38 PM Issue #1426 (Closed): enum logic[2:0] not generating enum in fst file
- Hi Wilson.
When declaring an enum as:
typedef enum logic[1:0] { ZERO=0, ONE, TWO, THREE } enumed_t; // Not wor... - 10:32 PM Issue #1425 (WillNotFix): Sensitivity lists with boolean expressions
- Verilator doesn't really do anything with sensitivity lists except posedge/negedge handling; it basically is followin...
- 11:57 AM Issue #1425 (WillNotFix): Sensitivity lists with boolean expressions
- Items in sensitivity lists can be expressions:...
- 10:27 PM Issue #1427 (Assigned): Incorrect real parameter assignment
- The duplicate nodes are because the values are being evaluated in the loop and previously deleted nodes reused. I sup...
- 05:31 PM Issue #1427: Incorrect real parameter assignment
- So I found one of the cases above that I was speculating about. I haven't fully determined why, but there are cases ...
- 02:40 PM Issue #1427 (Closed): Incorrect real parameter assignment
- See here for the test and a possible fix:
https://github.com/toddstrader/verilator-dev/tree/broken_real_param
The...
04/30/2019
- 11:17 PM Issue #1424 (Resolved): Verilator does not complain about invalid parameter declaration
- Fixed in git towards 4.014.
- 12:43 PM Issue #1424: Verilator does not complain about invalid parameter declaration
- Sounds perfect. Thank you!
- 11:19 AM Issue #1424 (Confirmed): Verilator does not complain about invalid parameter declaration
- Makes sense. Will do this then:
1. Add error when no initial value in pre-SV-2012.
2. Otherwise, change internal er... - 11:15 AM Issue #1424: Verilator does not complain about invalid parameter declaration
- From the referenced documentation it seems to me that initial value can be omitted only in exceptional cases, but I m...
- 10:19 AM Issue #1424 (AskedReporter): Verilator does not complain about invalid parameter declaration
- Parameter without initial values are legal in SystemVerilog 2017, this is not disabled when requesting earlier versio...
- 09:51 AM Issue #1424 (Closed): Verilator does not complain about invalid parameter declaration
- Verilator fails to trow syntax error on parameter declaration without constant expression, like this:...
- 08:25 AM Issue #1423 (Closed): 2 issues with unsized x/z constants
- Verilator is complaining about this code snippet, even if SV mode:...
04/29/2019
- 09:36 AM Issue #1422 (Feature): VPI hierarchy naming
- I agree 3 makes the most sense. Perhaps the TOP should also be suppressed in %m messages, that is it will look to ru...
- 08:38 AM Issue #1422 (NoFixNeeded): VPI hierarchy naming
- Hi,
I am currently looking into coupling cocotb and Verilator and stumbled over one major issue, that can be solve... - 09:35 AM Issue #1421: gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++17, remov...
- Thanks Wilson. Will do for next time.
- 09:34 AM Issue #1421 (Resolved): gtkwave/lz4.c uses the "register" storage class, which is deprecated in C...
- Pushed to git towards 4.013.
Note this file comes from GTKwave sources. I've emailed Tony Bybell to fix it, it wo... - 07:54 AM Issue #1421: gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++17, remov...
- Woops - line 251:...
- 07:53 AM Issue #1421 (Closed): gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++...
- https://en.cppreference.com/w/cpp/keyword/register
Line 251:...
04/28/2019
- 11:49 PM Issue #1363: CMake support
- Any movement on this Patrick? CMake is pretty popular, getting this in would make it so much easier to use Verilator ...
- 09:54 PM Issue #1419 (Closed): --trace-fst documentation issue
- Pushed to git, thanks.
04/23/2019
- 05:29 PM Issue #1305: Error messages do not contain hierarchical information
- I seem to have worked myself into a corner and therefore have backtracked a bit. I believe/hope this branch is ready...
Also available in: Atom