Activity
From 05/08/2019 to 06/06/2019
06/06/2019
- 11:57 PM Issue #1456: sameHash error on type parameters after 4.014
- Pushed, thanks.
- 01:40 PM Issue #1456: sameHash error on type parameters after 4.014
- Sorry, what do you think is missing? This commit hash the additional --debug-collision test:
https://github.com/tod... - 09:48 AM Issue #1456: sameHash error on type parameters after 4.014
- Suspect you forgot to push samehash-fix.
- 02:42 AM Issue #1456: sameHash error on type parameters after 4.014
- Sorry, one more update to the same branch:
https://github.com/toddstrader/verilator-dev/tree/samehash-fix
It dawn... - 12:46 AM Issue #1456 (Resolved): sameHash error on type parameters after 4.014
- Todd, great patch, thanks. Merged that, please file another bug if you can't look at #2, as I can't look immediately...
- 12:27 AM Issue #1456: sameHash error on type parameters after 4.014
- I re-ran the test suite with this fix and everything passes. I also rewound to just before the #1427 fix and tried o...
- 02:45 PM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- Wilson Snyder wrote:
> As the SystemC building is outside of Verilator, don't think Verilator itself has anything he... - 12:49 AM Issue #1445 (NoFixNeeded): simple sample doesn't poduce trace when using systemc 2.3
- Thanks for debugging. Not sure who gave the code to set SC_SIMCONTEXT_TRACING, recommend you feed that back upstream ...
06/05/2019
- 02:54 PM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- *Simple workaround*
With make edit_cache I set... - 10:48 AM Issue #1456: sameHash error on type parameters after 4.014
- This fixes the Ariane build, but my new test still has issues:
https://github.com/toddstrader/verilator-dev/tree/bug... - 12:35 AM Issue #1456: sameHash error on type parameters after 4.014
- Looks like I broke something with parameter types:
https://github.com/toddstrader/verilator-dev/tree/samehash-fix
...
06/04/2019
- 08:11 PM Issue #1456: sameHash error on type parameters after 4.014
- Ugh, smells like this guy:
https://www.veripool.org/issues/1427-Verilator-Incorrect-real-parameter-assignment
I p... - 07:48 PM Issue #1456 (Closed): sameHash error on type parameters after 4.014
- Hi,
when building the ariane core (https://github.com/pulp-platform/ariane) with the current master, I get the fol... - 11:05 AM Issue #1454: Support for loop index into generated arrays
- Verilator will unroll both kinds of loops. Generate loops are unrolled at a different stage, elaboration, which is a...
- 09:22 AM Issue #1454: Support for loop index into generated arrays
- Ok, then the issue is even deeper - why the synthesisable (i.e., constant-bound) behavioural for loops in Verilator a...
- 04:44 AM Issue #1455: Multi-threaded verilated simulation on single-core
- Thanks, Wilson! I will try asap.
It seems to me that it is deadlocked or livelocked somehow, it did not terminate ...
06/03/2019
- 11:17 PM Issue #1455 (Resolved): Multi-threaded verilated simulation on single-core
- Yes, there was a missing yield, so should be much better. Fixed in git towards 4.016.
Is there a reason why you're... - 05:28 PM Issue #1455 (Closed): Multi-threaded verilated simulation on single-core
- Hi,
I found an issue and before I dig deeper into it and try to solve it, I was wondering if you observed the issu... - 10:32 PM Issue #1454 (Feature): Support for loop index into generated arrays
- Verilator doesn't presently support runtime indexing into cells or named blocks. It does support generated indexing....
- 05:10 PM Issue #1454 (Feature): Support for loop index into generated arrays
- ...
- 11:29 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- Note this is waiting for a patch from someone, as CMAKE isn't the standard flow.
- 08:44 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- Martin Zaun wrote:
> * Verilator version used: 4.015
same behavior reproduced with verilator *4.014* (stable bran...
05/31/2019
- 11:35 AM Issue #1449 (Resolved): deferred assertion support
- Realized all that was needed was parser code pulled from Verilog-Perl.
Fixed in git towards 4.016.
- 09:28 AM Issue #1451: t_dist_whitespace.pl fails with --golden
- Yeah, my only concern with deleting branches is breaking all the URLs I'm depositing here (also mentioned in the arti...
- 12:41 AM Issue #1451 (Closed): t_dist_whitespace.pl fails with --golden
- Perfect, pushed to git towards 4.015.
BTW if you'd find it useful to see what of your branches have outstanding wo... - 12:25 AM Issue #1451 (Closed): t_dist_whitespace.pl fails with --golden
- ...
- 12:33 AM Issue #1305: Error messages do not contain hierarchical information
- I committed the error spacing change.
For option B I was assuming we'd clone filelines for each hier. Note we do ...
05/30/2019
- 12:02 PM Issue #1305: Error messages do not contain hierarchical information
- 1 + 2: This sounds good to me. I'll change to warnMore() and look for your commit.
3: This commit just made my da... - 01:01 AM Issue #1305: Error messages do not contain hierarchical information
- 1. First the trivial:
string locationMsg = msgPrefix()+locationStr;
Should be
string locatio... - 01:00 AM Issue #1305: Error messages do not contain hierarchical information
- 1. First the trivial:
string locationMsg = msgPrefix()+locationStr;
Should be
string locatio... - 03:14 AM Issue #1449: deferred assertion support
- I mean might you be able to come up with a patch that fixes the sources yourself, and/or provide a test_regress style...
- 02:58 AM Issue #1449: deferred assertion support
- Yeah, I'm not the best with linux, but given instructions, I would be happy to apply the patch and test it out. I'm u...
05/29/2019
- 10:45 PM Issue #1444 (Resolved): Invalid xml output generated when code contains functions with string arg...
- Great, thanks for the effort on this.
Pushed to git towards 4.016.
- 04:05 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Apologies for the delay. I have attached the latest patch for the fix.
The change now handles all ascii values (exce... - 10:31 PM Issue #1449 (Feature): deferred assertion support
- Seems straight forward to add this. Might you be willing to attempt a patch, or at least a self-checking test checke...
- 07:54 PM Issue #1449: deferred assertion support
- Error message:
syntax error, unexpected final, expecting '(' or property
code:
assert final ( !intf_data_in_64_4... - 07:53 PM Issue #1449 (Closed): deferred assertion support
- System verilog deferred assertions are treated as syntax errors:
http://systemverilog.us/vf/deferred_assertion.pdf - 05:26 PM Issue #1305: Error messages do not contain hierarchical information
- I updated the branch based on my musings about the presentation in #24:
https://github.com/toddstrader/verilator-dev...
05/28/2019
- 11:08 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- Looks like you've made some good progress debugging, can you please continue and get it to a patch to fix the issue?
05/24/2019
- 08:03 AM Issue #1307: Can not dump trace with CMAKE compiled SystemC library
- Another example which reproduces this issue with SystemC 2.3.3 is reported with bug1445. Example data available at ht...
05/22/2019
- 02:07 AM Issue #1439 (Feature): Add "included from" and macro expansion information in error messages
- 02:06 AM Issue #1430: Broken node on indexed interface modport
- Tracked this down to an issue that indexed interfaces with modports are broken in LinkDot. Stay tuned.
- 02:02 AM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
- Re time format:
IEEE does not say to print "ns" by default. I suspect what you have is a call to $timeformat speci...
05/21/2019
- 02:14 PM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
- Great, fix confirmed, thanks.
One very minor observation. For consistency with other simulators, could we suffix %...
05/18/2019
- 12:51 AM Issue #1427 (Resolved): Incorrect real parameter assignment
- Pushed to git towards 4.015. Just replaced two minor C++11 isms.
Thanks again for the work.
05/17/2019
- 10:27 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- From https://www.liquid-technologies.com/xml/escapingdata.aspx
says you can character escape unicode format in dec... - 09:45 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Do you mean U+0005 control character? My understanding is that it is not allowed in XML 1.0 [https://en.wikipedia.org...
- 09:37 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Please add a \005 to the test and I suspect you'll see we need to also ampersand-number quote non-ascii similar to th...
- 06:54 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Patch for the fix is attached. Includes test update.
- 01:41 AM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- 0001 looks good, I just changed some spacing to bring up to newer standard (no tabs). Pushed to git in 4.015.
- 08:54 PM Issue #1427: Incorrect real parameter assignment
- Thanks again for the feedback. I've updated the branch to reflect all of this:
https://github.com/toddstrader/veril... - 10:52 AM Issue #1427: Incorrect real parameter assignment
- I looked through and am a bit fuzzy on why interfaces are handled this way. I think the idea is that each parameteriz...
- 08:41 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- OS & compiler used in report:
* Linux Ubuntu 16.04
* gcc 5.4
URL to reference data/project somehow was lost as... - 08:36 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- Comparing configure vs. CMAKE (details see attached file):
* systemc 2.3.3 build via configure is producing correc... - 01:22 AM Issue #1441 (Resolved): incorrect handling of strings in display and sformatf
- Both issues fixed in git towards 4.015.
05/16/2019
- 11:39 PM Issue #1443 (Resolved): Calling $display with real %t argument causes segfault in _vl_vsformat
- Thanks for the test case.
Basically %t didn't support real numbers ($realtime).
Fixed in git towards 4.015.
- 03:44 PM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
- The segfault seems to be dependent upon the %t time format output, and the call to $realtime also being present.
W... - 03:37 PM Issue #1443 (Closed): Calling $display with real %t argument causes segfault in _vl_vsformat
- Standalone minimal test case attached
Output running executable under GDB:
TestCase at 1 this is fine
TestCase... - 10:56 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- First patch to relocate quoteNameControls function from V3Number to V3OutFormatter is attached.
Please let me know... - 06:46 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- Thanks for taking this on & asking.
V3Number::quoteNameControls really is in the wrong place, I would suggest firs... - 04:42 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
- I can work on a fix. What I am not sure is whether
* Add language argument to V3Number::quoteNameControls function
... - 04:37 PM Issue #1444 (Confirmed): Invalid xml output generated when code contains functions with string ar...
- Your diagnosis sounds reasonable, perhaps you could provide a patch? Probably V3File's OutFormatter is the right spo...
- 03:47 PM Issue #1444 (Closed): Invalid xml output generated when code contains functions with string argum...
- For the attached code (topmod.sv), verilator (4.014) is generating invalid xml output (attached Vtopmod.xml).
The ... - 10:43 PM Issue #1427: Incorrect real parameter assignment
- Great, thanks for the feedback. I haven't had any more time to look at this once since I last posted, so I'm still c...
- 10:13 PM Issue #1427: Incorrect real parameter assignment
- Sorry, forgot this one needed reply.
On a collision not reusing sounds fine, I'd keep new one.
For collision te... - 09:55 PM Issue #1445 (AskedReporter): simple sample doesn't poduce trace when using systemc 2.3
- Sounds same as bug1307. I use 2.3.3 for all testing and do not see this problem, if you can figure it out please pos...
- 04:32 PM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
- This may be same problem as Issue #1307, since I build SystemC 2.3.3 with CMAKE.
- 04:25 PM Issue #1445 (NoFixNeeded): simple sample doesn't poduce trace when using systemc 2.3
* Verilator version used: 4.015
* SystemC built on Linux from original reference sources by accelera.org
* There ...- 01:58 AM Issue #1441 (Confirmed): incorrect handling of strings in display and sformatf
- Thanks for putting this in test_regress format, that helps.
First bug is at present it assumes %h when no display ... - 01:44 AM Issue #1442 (Confirmed): Enum value not made sized when enum sized
- I suspect you added the LEN casts to try to work around this, but note they are unnecessary to show the problem, whic...
- 12:50 AM Issue #1442: Enum value not made sized when enum sized
- Verilator 4.015 devel rev UNKNOWN_REV
- 12:48 AM Issue #1442: Enum value not made sized when enum sized
- $ verilator --lint-only test.v
%Warning-WIDTHCONCAT: test.v:8:
Unsized numbers/parameters not allowed in conc... - 12:38 AM Issue #1442 (Closed): Enum value not made sized when enum sized
- ...
05/15/2019
- 11:02 PM Issue #1438 (Closed): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- Good, pushed to git.
Made minor change to add a "cd" to make it work here & checked still works with worktree so h... - 06:48 PM Issue #1438: Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- Yeah, makes sense. Let's try it this way instead:
https://github.com/toddstrader/verilator-dev/tree/manifest-from-g... - 12:22 AM Issue #1438 (AskedReporter): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- I don't like this because it ignores things like *.pdf, and forgotten PDFs are exactly the thing which this test was ...
- 02:51 PM Issue #1441 (Closed): incorrect handling of strings in display and sformatf
- $display of a string parameter or an expression with type string produces incorrect result in certain cases.
Please ... - 12:52 AM Issue #1440: V3Ast.cpp gives warning with -Winvalid-noreturn
- Awesome, thanks for the clarification!
- 12:52 AM Issue #1440: V3Ast.cpp gives warning with -Winvalid-noreturn
- Pushed to git towards 4.016.
- 12:51 AM Issue #1440 (Closed): V3Ast.cpp gives warning with -Winvalid-noreturn
- Your fix looks good, there were also two other similar sections of code I patched.
The assert will never get hit, ...
05/14/2019
- 10:17 PM Issue #1440 (Closed): V3Ast.cpp gives warning with -Winvalid-noreturn
- Compiling src/V3Ast.cpp produces the following warning when compiled with -Winvalid-noreturn (Apple LLVM version 10.0...
- 09:53 PM Issue #1435: Report column numbers and source text in error messages
- Sure, sign me up. However, I've got a lot of irons in the Verilator fire right now so this may take a while to get t...
- 09:51 PM Issue #1439 (Closed): Add "included from" and macro expansion information in error messages
- Ideally Verilator would report messages similar to gcc in these scenarios. Something like this:...
- 09:04 PM Issue #1305: Error messages do not contain hierarchical information
- Inlining is a bummer wrt to this issue. It seems like we'd have to possibly tag every node with a scope name before ...
- 08:53 PM Issue #1438 (Closed): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
- I'm using .git/info/exclude to locally ignore a directory that gets created in my Verilator repo by a code completion...
- 10:51 AM Issue #1436 (Resolved): Add an option to silence the command-failed message
- Thanks for updating. Pushed to git towards 4.016.
- 09:40 AM Issue #1436: Add an option to silence the command-failed message
- Updated at:
https://github.com/toddstrader/verilator-dev/tree/quiet_error - 10:35 AM Issue #1437 (Resolved): -Wsign-compare warning in verilated.cpp
- Well done, thanks for the good work.
Fixed in git towards 4.016.
- 07:16 AM Issue #1437 (Closed): -Wsign-compare warning in verilated.cpp
- I do not use verilated.mk to compile the generated C++ code, and I get these warnings (CFLAGS = -Wall -Wextra)
...
05/13/2019
- 11:32 PM Issue #1305: Error messages do not contain hierarchical information
- Please pull from master and see test_regress/t/t_param_scope_bad and test_regress/t/t_clk_scope_bad
These are exam... - 06:16 PM Issue #1305: Error messages do not contain hierarchical information
- > 1. I don't think you should attach scopeName to modules.
I presume we're talking about m_hierName. Is this real... - 10:46 PM Issue #1435 (Feature): Report column numbers and source text in error messages
- Are you interested in making the column/source printing change? Here's some notes.
I'd think two separate patch s... - 06:19 PM Issue #1435 (Closed): Report column numbers and source text in error messages
- Re: Wilson's suggestion in issue #1305, we should report column numbers and source text in error messages like gcc do...
- 10:36 PM Issue #1436 (Feature): Add an option to silence the command-failed message
- Seems reasonable. Please two things then will merge, 1. need documentation for flag (you did summary but not the lar...
- 09:58 PM Issue #1436 (Closed): Add an option to silence the command-failed message
- Often times my command line invocation of Verilator is so large that this pushes the actual error message off the scr...
- 04:05 PM Issue #1434 (NoFixNeeded): systemverilog Scoped types in enums support
- You're referencing "T::" e.g. package T, but have not declared it as required by IEEE.
I suspect what you want is ... - 03:42 PM Issue #1434 (NoFixNeeded): systemverilog Scoped types in enums support
- ...
05/12/2019
- 07:56 PM Issue #1305: Error messages do not contain hierarchical information
- 1. I don't think you should attach scopeName to modules. A module may have many uses at different scopes. Instead, l...
- 12:20 PM Issue #1433 (Resolved): Warnings from unused parameters in verilated_fst_c.h
- Wall done. I also passed set_time_resolution call down to the VerilatedFst class which would be needed if we ever get...
- 05:01 AM Issue #1433: Warnings from unused parameters in verilated_fst_c.h
- I have attached a patch file that adds the cast to the ...
- 02:54 AM Issue #1433 (Closed): Warnings from unused parameters in verilated_fst_c.h
- In my current project I get some warnings from unused parameters. Since this in the FST header, it gets pulled into m...
05/10/2019
- 01:35 PM Issue #1305: Error messages do not contain hierarchical information
- Here's the rest (actual error location reporting) which has been rebased onto upstream:
https://github.com/toddstrad... - 12:03 AM Issue #1305: Error messages do not contain hierarchical information
- v3number_hier_2 is pushed to git, just cleaned up some spacing and names, thanks for this.
- 12:30 AM Issue #1326 (NotEnoughInfo): Comb Logic order problem
- Didn't get more information - if you have more to go on please post.
- 12:29 AM Issue #1407 (NotEnoughInfo): facing a error for verilatedvcdsc
- Didn't hear back & presume you got it working. If you have tips to post for others that hit similar issues please upd...
- 12:28 AM Issue #1351 (WillNotFix): Support for loading stimulus from VCD file
- VCD stimulus applying isn't really directly related to Verilator, and unlikely would get to do this in the forseeable...
05/09/2019
- 11:25 PM Issue #1408 (WillNotFix): Support concatenation select
- As earlier commented, not supported by big simulators, so not fixing for now; if the others support this will revisit.
- 07:03 AM Issue #1424: Verilator does not complain about invalid parameter declaration
- It works. Thank you very much!
- 01:37 AM Issue #1424 (Closed): Verilator does not complain about invalid parameter declaration
- In 4.014.
- 01:38 AM Issue #1431 (Closed): Multiple local variables with the same name ( __Vtable1_valid ) generated i...
- In 4.014.
- 01:38 AM Issue #1426 (Closed): enum logic[2:0] not generating enum in fst file
- In 4.014.
- 01:38 AM Issue #1421 (Closed): gtkwave/lz4.c uses the "register" storage class, which is deprecated in C++...
- In 4.014.
- 01:38 AM Issue #1417 (Closed): FST regression tests fail instead of skip if fst2vcd isn't installed
- In 4.014.
- 01:37 AM Issue #1413 (Closed): Wrong printf/scanf format specifiers used for MinGW targets
- In 4.014.
- 01:37 AM Issue #1415 (Closed): Verilator generates calls to an undefined function named: VL_SHIFTR_QQW
- In 4.014.
- 01:37 AM Issue #1412 (Closed): Verilator generates calls to an undefined function named: VL_SHIFTL_QQW
- In 4.014.
- 01:37 AM Issue #1423 (Closed): 2 issues with unsized x/z constants
- In 4.014.
- 01:37 AM Issue #1411 (Closed): # comments support in .mem files
- In 4.014.
- 01:36 AM Verilator 4.014 Released
- Verilator 4.014 2019-05-08
*** Add --trace-fst-thread.
**** Support '#' comments in $readmem, bug1411. [Fred...
05/08/2019
- 11:11 AM Issue #1305: Error messages do not contain hierarchical information
- The v3number patches look reasonable. Tonight (ish) I'll push a release, then apply this with some spacing fixes.
- 01:59 AM Issue #1423 (Resolved): 2 issues with unsized x/z constants
- X/Z extension fixed with warning in git towards 4.014.
Also available in: Atom