Project

General

Profile

[logo] 
 
Home
News
Activity
About/Contact
Major Tools
  Dinotrace
  Verilator
  Verilog-mode
  Verilog-Perl
Other Tools
  IPC::Locker
  Parallel::Forker
  Voneline
General Info
  Papers

Activity

From 05/14/2019 to 06/12/2019

06/12/2019

11:17 PM Issue #1462 (Resolved): signal redeclaration is not reported
Yes, some duplicates weren't reported.
Fixed in git towards 4.015.
Wilson Snyder
01:38 PM Issue #1462 (Closed): signal redeclaration is not reported
I am using verilator to lint verilog modules which will be then synthesized by Xilinx tools. Prior to synthesis veril... Peter Gerst
01:38 AM Issue #1460 (Resolved): fstapi.c compile errors.
Looks good, thanks for the efforts.
Pushed to git towards 4.015.
Wilson Snyder
12:47 AM Issue #1460: fstapi.c compile errors.
Hi,
Yes, did it. Here's the new and improved patch that hopefully has a minimal effect on everyone else. I added...
Richard Myers

06/11/2019

11:00 PM Issue #1458 (Resolved): Dotted references to type parameters do not have the correct size
Wilson Snyder
11:00 PM Issue #1458: Dotted references to type parameters do not have the correct size
Golden, thanks. Looks like one of those sort of patches which requires hours of thought to result in just one patche... Wilson Snyder
11:01 AM Issue #1458: Dotted references to type parameters do not have the correct size
OK, so I actually ran all the tests this time:
https://github.com/toddstrader/verilator-dev/tree/samehash-test
Th...
Todd Strader
10:52 PM Issue #1460 (AskedReporter): fstapi.c compile errors.
Thanks for debugging.
_WORDSIZE is defined in sys/types.h and your patch moves the test above this include, so I t...
Wilson Snyder
06:20 AM Issue #1460 (Closed): fstapi.c compile errors.
Hi,
I get many errors like the following with Verilator 4.014 (and before) when compiling fstapi using mingw32 (un...
Richard Myers

06/08/2019

11:06 PM Issue #1458: Dotted references to type parameters do not have the correct size
Sigh, this issue isn't working out well for me. So #1456 isn't totally fixed then. I'm getting AstBasicDTypes in pa... Todd Strader
10:01 PM Issue #1458: Dotted references to type parameters do not have the correct size
Um, now t_type_param.pl looks good but t_type_param_collision.pl fails.
Wilson Snyder
12:25 PM Issue #1458: Dotted references to type parameters do not have the correct size
Ugh, yup. I think I started with $bits(foo_inst.bar) before I added baz. In any case, this fixes the commented port... Todd Strader
03:18 AM Issue #1458 (AskedReporter): Dotted references to type parameters do not have the correct size
For the second commented section, it refers to baz is a parameter set to a $bits. $bits is by IEEE a 32-bit return v... Wilson Snyder

06/07/2019

03:22 PM Issue #1458 (Closed): Dotted references to type parameters do not have the correct size
See the commented out portions of t_type_param.v. Perhaps this shouldn't even be allowed since it can cause elaborat... Todd Strader

06/06/2019

11:57 PM Issue #1456: sameHash error on type parameters after 4.014
Pushed, thanks. Wilson Snyder
01:40 PM Issue #1456: sameHash error on type parameters after 4.014
Sorry, what do you think is missing? This commit hash the additional --debug-collision test:
https://github.com/tod...
Todd Strader
09:48 AM Issue #1456: sameHash error on type parameters after 4.014
Suspect you forgot to push samehash-fix.
Wilson Snyder
02:42 AM Issue #1456: sameHash error on type parameters after 4.014
Sorry, one more update to the same branch:
https://github.com/toddstrader/verilator-dev/tree/samehash-fix
It dawn...
Todd Strader
12:46 AM Issue #1456 (Resolved): sameHash error on type parameters after 4.014
Todd, great patch, thanks. Merged that, please file another bug if you can't look at #2, as I can't look immediately... Wilson Snyder
12:27 AM Issue #1456: sameHash error on type parameters after 4.014
I re-ran the test suite with this fix and everything passes. I also rewound to just before the #1427 fix and tried o... Todd Strader
02:45 PM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
Wilson Snyder wrote:
> As the SystemC building is outside of Verilator, don't think Verilator itself has anything he...
Martin Zaun
12:49 AM Issue #1445 (NoFixNeeded): simple sample doesn't poduce trace when using systemc 2.3
Thanks for debugging. Not sure who gave the code to set SC_SIMCONTEXT_TRACING, recommend you feed that back upstream ... Wilson Snyder

06/05/2019

02:54 PM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
*Simple workaround*
With make edit_cache I set...
Martin Zaun
10:48 AM Issue #1456: sameHash error on type parameters after 4.014
This fixes the Ariane build, but my new test still has issues:
https://github.com/toddstrader/verilator-dev/tree/bug...
Todd Strader
12:35 AM Issue #1456: sameHash error on type parameters after 4.014
Looks like I broke something with parameter types:
https://github.com/toddstrader/verilator-dev/tree/samehash-fix
...
Todd Strader

06/04/2019

08:11 PM Issue #1456: sameHash error on type parameters after 4.014
Ugh, smells like this guy:
https://www.veripool.org/issues/1427-Verilator-Incorrect-real-parameter-assignment
I p...
Todd Strader
07:48 PM Issue #1456 (Closed): sameHash error on type parameters after 4.014
Hi,
when building the ariane core (https://github.com/pulp-platform/ariane) with the current master, I get the fol...
Stefan Wallentowitz
11:05 AM Issue #1454: Support for loop index into generated arrays
Verilator will unroll both kinds of loops. Generate loops are unrolled at a different stage, elaboration, which is a... Wilson Snyder
09:22 AM Issue #1454: Support for loop index into generated arrays
Ok, then the issue is even deeper - why the synthesisable (i.e., constant-bound) behavioural for loops in Verilator a... X Yyy
04:44 AM Issue #1455: Multi-threaded verilated simulation on single-core
Thanks, Wilson! I will try asap.
It seems to me that it is deadlocked or livelocked somehow, it did not terminate ...
Stefan Wallentowitz

06/03/2019

11:17 PM Issue #1455 (Resolved): Multi-threaded verilated simulation on single-core
Yes, there was a missing yield, so should be much better. Fixed in git towards 4.016.
Is there a reason why you're...
Wilson Snyder
05:28 PM Issue #1455 (Closed): Multi-threaded verilated simulation on single-core
Hi,
I found an issue and before I dig deeper into it and try to solve it, I was wondering if you observed the issu...
Stefan Wallentowitz
10:32 PM Issue #1454 (Feature): Support for loop index into generated arrays
Verilator doesn't presently support runtime indexing into cells or named blocks. It does support generated indexing.... Wilson Snyder
05:10 PM Issue #1454 (Feature): Support for loop index into generated arrays
... X Yyy
11:29 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
Note this is waiting for a patch from someone, as CMAKE isn't the standard flow.
Wilson Snyder
08:44 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
Martin Zaun wrote:
> * Verilator version used: 4.015
same behavior reproduced with verilator *4.014* (stable bran...
Martin Zaun

05/31/2019

11:35 AM Issue #1449 (Resolved): deferred assertion support
Realized all that was needed was parser code pulled from Verilog-Perl.
Fixed in git towards 4.016.
Wilson Snyder
09:28 AM Issue #1451: t_dist_whitespace.pl fails with --golden
Yeah, my only concern with deleting branches is breaking all the URLs I'm depositing here (also mentioned in the arti... Todd Strader
12:41 AM Issue #1451 (Closed): t_dist_whitespace.pl fails with --golden
Perfect, pushed to git towards 4.015.
BTW if you'd find it useful to see what of your branches have outstanding wo...
Wilson Snyder
12:25 AM Issue #1451 (Closed): t_dist_whitespace.pl fails with --golden
... Todd Strader
12:33 AM Issue #1305: Error messages do not contain hierarchical information
I committed the error spacing change.
For option B I was assuming we'd clone filelines for each hier. Note we do ...
Wilson Snyder

05/30/2019

12:02 PM Issue #1305: Error messages do not contain hierarchical information
1 + 2: This sounds good to me. I'll change to warnMore() and look for your commit.
3: This commit just made my da...
Todd Strader
01:01 AM Issue #1305: Error messages do not contain hierarchical information
1. First the trivial:
string locationMsg = msgPrefix()+locationStr;
Should be
string locatio...
Wilson Snyder
01:00 AM Issue #1305: Error messages do not contain hierarchical information
1. First the trivial:
string locationMsg = msgPrefix()+locationStr;
Should be
string locatio...
Wilson Snyder
03:14 AM Issue #1449: deferred assertion support
I mean might you be able to come up with a patch that fixes the sources yourself, and/or provide a test_regress style... Wilson Snyder
02:58 AM Issue #1449: deferred assertion support
Yeah, I'm not the best with linux, but given instructions, I would be happy to apply the patch and test it out. I'm u... Charles Eddleston

05/29/2019

10:45 PM Issue #1444 (Resolved): Invalid xml output generated when code contains functions with string arg...
Great, thanks for the effort on this.
Pushed to git towards 4.016.
Wilson Snyder
04:05 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
Apologies for the delay. I have attached the latest patch for the fix.
The change now handles all ascii values (exce...
Kanad Kanhere
10:31 PM Issue #1449 (Feature): deferred assertion support
Seems straight forward to add this. Might you be willing to attempt a patch, or at least a self-checking test checke... Wilson Snyder
07:54 PM Issue #1449: deferred assertion support
Error message:
syntax error, unexpected final, expecting '(' or property
code:
assert final ( !intf_data_in_64_4...
Charles Eddleston
07:53 PM Issue #1449 (Closed): deferred assertion support
System verilog deferred assertions are treated as syntax errors:
http://systemverilog.us/vf/deferred_assertion.pdf
Charles Eddleston
05:26 PM Issue #1305: Error messages do not contain hierarchical information
I updated the branch based on my musings about the presentation in #24:
https://github.com/toddstrader/verilator-dev...
Todd Strader

05/28/2019

11:08 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
Looks like you've made some good progress debugging, can you please continue and get it to a patch to fix the issue?
Wilson Snyder

05/24/2019

08:03 AM Issue #1307: Can not dump trace with CMAKE compiled SystemC library
Another example which reproduces this issue with SystemC 2.3.3 is reported with bug1445. Example data available at ht... Martin Zaun

05/22/2019

02:07 AM Issue #1439 (Feature): Add "included from" and macro expansion information in error messages
Wilson Snyder
02:06 AM Issue #1430: Broken node on indexed interface modport
Tracked this down to an issue that indexed interfaces with modports are broken in LinkDot. Stay tuned.
Wilson Snyder
02:02 AM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
Re time format:
IEEE does not say to print "ns" by default. I suspect what you have is a call to $timeformat speci...
Wilson Snyder

05/21/2019

02:14 PM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
Great, fix confirmed, thanks.
One very minor observation. For consistency with other simulators, could we suffix %...
Julien Margetts

05/18/2019

12:51 AM Issue #1427 (Resolved): Incorrect real parameter assignment
Pushed to git towards 4.015. Just replaced two minor C++11 isms.
Thanks again for the work.
Wilson Snyder

05/17/2019

10:27 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
From https://www.liquid-technologies.com/xml/escapingdata.aspx
says you can character escape unicode format in dec...
Wilson Snyder
09:45 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
Do you mean U+0005 control character? My understanding is that it is not allowed in XML 1.0 [https://en.wikipedia.org... Kanad Kanhere
09:37 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
Please add a \005 to the test and I suspect you'll see we need to also ampersand-number quote non-ascii similar to th... Wilson Snyder
06:54 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
Patch for the fix is attached. Includes test update.
Kanad Kanhere
01:41 AM Issue #1444: Invalid xml output generated when code contains functions with string arguments
0001 looks good, I just changed some spacing to bring up to newer standard (no tabs). Pushed to git in 4.015.
Wilson Snyder
08:54 PM Issue #1427: Incorrect real parameter assignment
Thanks again for the feedback. I've updated the branch to reflect all of this:
https://github.com/toddstrader/veril...
Todd Strader
10:52 AM Issue #1427: Incorrect real parameter assignment
I looked through and am a bit fuzzy on why interfaces are handled this way. I think the idea is that each parameteriz... Wilson Snyder
08:41 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
OS & compiler used in report:
* Linux Ubuntu 16.04
* gcc 5.4
URL to reference data/project somehow was lost as...
Martin Zaun
08:36 AM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
Comparing configure vs. CMAKE (details see attached file):
* systemc 2.3.3 build via configure is producing correc...
Martin Zaun
01:22 AM Issue #1441 (Resolved): incorrect handling of strings in display and sformatf
Both issues fixed in git towards 4.015.
Wilson Snyder

05/16/2019

11:39 PM Issue #1443 (Resolved): Calling $display with real %t argument causes segfault in _vl_vsformat
Thanks for the test case.
Basically %t didn't support real numbers ($realtime).
Fixed in git towards 4.015.
Wilson Snyder
03:44 PM Issue #1443: Calling $display with real %t argument causes segfault in _vl_vsformat
The segfault seems to be dependent upon the %t time format output, and the call to $realtime also being present.
W...
Julien Margetts
03:37 PM Issue #1443 (Closed): Calling $display with real %t argument causes segfault in _vl_vsformat
Standalone minimal test case attached
Output running executable under GDB:
TestCase at 1 this is fine
TestCase...
Julien Margetts
10:56 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
First patch to relocate quoteNameControls function from V3Number to V3OutFormatter is attached.
Please let me know...
Kanad Kanhere
06:46 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
Thanks for taking this on & asking.
V3Number::quoteNameControls really is in the wrong place, I would suggest firs...
Wilson Snyder
04:42 PM Issue #1444: Invalid xml output generated when code contains functions with string arguments
I can work on a fix. What I am not sure is whether
* Add language argument to V3Number::quoteNameControls function
...
Kanad Kanhere
04:37 PM Issue #1444 (Confirmed): Invalid xml output generated when code contains functions with string ar...
Your diagnosis sounds reasonable, perhaps you could provide a patch? Probably V3File's OutFormatter is the right spo... Wilson Snyder
03:47 PM Issue #1444 (Closed): Invalid xml output generated when code contains functions with string argum...
For the attached code (topmod.sv), verilator (4.014) is generating invalid xml output (attached Vtopmod.xml).
The ...
Kanad Kanhere
10:43 PM Issue #1427: Incorrect real parameter assignment
Great, thanks for the feedback. I haven't had any more time to look at this once since I last posted, so I'm still c... Todd Strader
10:13 PM Issue #1427: Incorrect real parameter assignment
Sorry, forgot this one needed reply.
On a collision not reusing sounds fine, I'd keep new one.
For collision te...
Wilson Snyder
09:55 PM Issue #1445 (AskedReporter): simple sample doesn't poduce trace when using systemc 2.3
Sounds same as bug1307. I use 2.3.3 for all testing and do not see this problem, if you can figure it out please pos... Wilson Snyder
04:32 PM Issue #1445: simple sample doesn't poduce trace when using systemc 2.3
This may be same problem as Issue #1307, since I build SystemC 2.3.3 with CMAKE.
Martin Zaun
04:25 PM Issue #1445 (NoFixNeeded): simple sample doesn't poduce trace when using systemc 2.3

* Verilator version used: 4.015
* SystemC built on Linux from original reference sources by accelera.org
* There ...
Martin Zaun
01:58 AM Issue #1441 (Confirmed): incorrect handling of strings in display and sformatf
Thanks for putting this in test_regress format, that helps.
First bug is at present it assumes %h when no display ...
Wilson Snyder
01:44 AM Issue #1442 (Confirmed): Enum value not made sized when enum sized
I suspect you added the LEN casts to try to work around this, but note they are unnecessary to show the problem, whic... Wilson Snyder
12:50 AM Issue #1442: Enum value not made sized when enum sized
Verilator 4.015 devel rev UNKNOWN_REV Dan Petrisko
12:48 AM Issue #1442: Enum value not made sized when enum sized
$ verilator --lint-only test.v
%Warning-WIDTHCONCAT: test.v:8:
Unsized numbers/parameters not allowed in conc...
Dan Petrisko
12:38 AM Issue #1442 (Closed): Enum value not made sized when enum sized
... Dan Petrisko

05/15/2019

11:02 PM Issue #1438 (Closed): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
Good, pushed to git.
Made minor change to add a "cd" to make it work here & checked still works with worktree so h...
Wilson Snyder
06:48 PM Issue #1438: Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
Yeah, makes sense. Let's try it this way instead:
https://github.com/toddstrader/verilator-dev/tree/manifest-from-g...
Todd Strader
12:22 AM Issue #1438 (AskedReporter): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
I don't like this because it ignores things like *.pdf, and forgotten PDFs are exactly the thing which this test was ... Wilson Snyder
02:51 PM Issue #1441 (Closed): incorrect handling of strings in display and sformatf
$display of a string parameter or an expression with type string produces incorrect result in certain cases.
Please ...
Denis Rystsov
12:52 AM Issue #1440: V3Ast.cpp gives warning with -Winvalid-noreturn
Awesome, thanks for the clarification! Kevin Kiningham
12:52 AM Issue #1440: V3Ast.cpp gives warning with -Winvalid-noreturn
Pushed to git towards 4.016.
Wilson Snyder
12:51 AM Issue #1440 (Closed): V3Ast.cpp gives warning with -Winvalid-noreturn
Your fix looks good, there were also two other similar sections of code I patched.
The assert will never get hit, ...
Wilson Snyder

05/14/2019

10:17 PM Issue #1440 (Closed): V3Ast.cpp gives warning with -Winvalid-noreturn
Compiling src/V3Ast.cpp produces the following warning when compiled with -Winvalid-noreturn (Apple LLVM version 10.0... Kevin Kiningham
09:53 PM Issue #1435: Report column numbers and source text in error messages
Sure, sign me up. However, I've got a lot of irons in the Verilator fire right now so this may take a while to get t... Todd Strader
09:51 PM Issue #1439 (Closed): Add "included from" and macro expansion information in error messages
Ideally Verilator would report messages similar to gcc in these scenarios. Something like this:... Todd Strader
09:04 PM Issue #1305: Error messages do not contain hierarchical information
Inlining is a bummer wrt to this issue. It seems like we'd have to possibly tag every node with a scope name before ... Todd Strader
08:53 PM Issue #1438 (Closed): Files ignored by .git/info/exclude make t_dist_manifest.pl unhappy
I'm using .git/info/exclude to locally ignore a directory that gets created in my Verilator repo by a code completion... Todd Strader
10:51 AM Issue #1436 (Resolved): Add an option to silence the command-failed message
Thanks for updating. Pushed to git towards 4.016.
Wilson Snyder
09:40 AM Issue #1436: Add an option to silence the command-failed message
Updated at:
https://github.com/toddstrader/verilator-dev/tree/quiet_error
Todd Strader
10:35 AM Issue #1437 (Resolved): -Wsign-compare warning in verilated.cpp
Well done, thanks for the good work.
Fixed in git towards 4.016.
Wilson Snyder
07:16 AM Issue #1437 (Closed): -Wsign-compare warning in verilated.cpp
I do not use verilated.mk to compile the generated C++ code, and I get these warnings (CFLAGS = -Wall -Wextra)
...
Sergey Kvachonok
 

Also available in: Atom